Closed
Bug 1609024
Opened 5 years ago
Closed 5 years ago
Audit whether we need mPrefersReducedMotionCached or not in these days
Categories
(Core :: Widget, task, P3)
Core
Widget
Tracking
()
RESOLVED
FIXED
mozilla78
| Tracking | Status | |
|---|---|---|
| firefox78 | --- | fixed |
People
(Reporter: hiro, Assigned: emilio)
Details
Attachments
(1 file)
I had to introduce the variable to avoid clearing the pref value set in test before we query the value in child processes, but in these days, it might not be necessary. Or maybe it has been unnecessary in the first place. I don't remember.
|
Assignee | |
Comment 1•5 years ago
|
||
This is not only about mPrefersReducedMotionCached, but also about the mShouldRetainCacheForTest and such... I'll take a look.
Flags: needinfo?(emilio)
|
|
Assignee | |
Updated•5 years ago
|
Flags: needinfo?(emilio)
|
|
Assignee | |
Comment 2•5 years ago
|
||
I don't think all this complexity is worth it for having a
marginally-more-realistic testing story. Using the pref just works and we should
do that, I think.
|
||
Updated•5 years ago
|
Assignee: nobody → emilio
Status: NEW → ASSIGNED
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7ded7f391f1b
Remove cache mechanism which is not very useful. r=hiro,snorp,mccr8
Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ecb4bffa98bb
Un-skip browser_layoutHelpers.js on Linux as the test is fixed. a=test-only
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/7ded7f391f1b
https://hg.mozilla.org/mozilla-central/rev/ecb4bffa98bb
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox78:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
You need to log in
before you can comment on or make changes to this bug.
Description
•