Mac's Keyboard Shortcuts are not working with the latest Firefox
Categories
(Core :: Widget: Cocoa, defect, P3)
Tracking
()
People
(Reporter: www.squad, Unassigned)
Details
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:72.0) Gecko/20100101 Firefox/72.0
Steps to reproduce:
When custom keyboard shortcuts are set via MacOS
System Preferences -> Keyboard -> Shortcuts -> App Shortcuts
for the menu items "Select Location Bar" and "Bookmark This Page" - they do not work as intended.
The menu item "Select Location Bar" is no longer present in the Firefox menu, so that could be one thing.
However, "Bookmark This Page" is not only present, in the Menu bar the displayed keyboard shortcut is displayed as altered by my preference. Yet, when I push the combination of "Cmd+D" - it triggers the "Bookmark This Page" functionality, disregarding the custom set shortcut.
As displayed in this screenshot, I am trying to use "Cmd+L" to bookmark a page:
https://pasteboard.co/IPSoq8X.png
Yet, when I hit that combination it focuses the address bar.
Actual results:
Attempting to remap default keyboard shortcuts fails to take any effect. Shortcuts for "Select Location Bar" and "Bookmark This Page" are ignored when set through the "App Shortcuts" functionality on Mac
Expected results:
I have used Firefox and Chrome on my Mac for a few years and I have never had a problem switching the keyboard shortcuts for "Select Location Bar" and "Bookmark This Page":
https://pasteboard.co/IPSprfW.png
With version 72 this functionality is broken and even attempting to remap only "Bookmark This Page" doesn't free the button combination of "Cmd+D", whereas previously it did and users were able to use their own preferable keyboard combinations.
|
||
Updated•4 years ago
|
Why would you mark the bug as "Duplicate" to a 12 year old bug, instead of trying to recreate the problem?
The bug you marked this as "Duplicate" to was filed 12 years ago, closed 3 years ago. The problem I am describing is not for an old version of Firefox, it is for the LATEST version.
This is very clearly not the same problem. We did not have Firefox 72 3 years ago!
|
|
||
Comment 3•4 years ago
|
||
At first glance, this looked like a dupe of bug 429824. Thanks for the NI.
At a second view, on the latest Nightly 74.0a1 and Mac OS X 10.14, I'm being able to access the ''Bookmark This Page" option with a remapped preference - I used Cmd+Shift+M, I can't do it though on Firefox 72.0.1.
Tried also to add the remapped Cmd+L shortcut to access the "Bookmark this Page" option, but that didn't work at all, neither on Firefox 72.0.2 nor on the latest Nightly 74.0a1, not sure if it's because this shortcut might already be hardcoded for the "Select Location" or not.
Stephen, do you have any idea of what's happening here?
|
|
||
Updated•4 years ago
|
|
||
Comment 4•4 years ago
|
||
This is actually a duplicate of bug 1333781, which covers remapped shortcuts that weren't addressed in bug 429824.
(In reply to Stephen A Pohl [:spohl] from comment #4)
This is actually a duplicate of bug 1333781, which covers remapped shortcuts that weren't addressed in bug 429824.
*** This bug has been marked as a duplicate of bug 1333781 ***
I am sorry, but can you clarify your stance on this.
First and foremost, you are marking this as a Duplicate to a bug reported !!! 3 YEARS AGO !!! whereas shortcuts used to work up until very recently. You don't have to take my word on it, @Simona Badau confirmed that they worked in the Nightly 74.0a1 but not on the released 72.0.1. This is not a version from 3 years ago!
Secondly, since this is obviously confirmed to be working in a nightly built, wouldn't it be more appropriate for a person of your status to actually look into what was changed between 74.0a1 and 72.0.1 (more like what's missing) and submit a proposal that addresses this situation ?
Looking forward to your reply before I give up completely on using Firefox once and for all.
Sincerely,
Dave
|
|
||
Comment 6•4 years ago
|
||
Could you run mozregression[1] to see when exactly this started happening? If you have never run mozregression before, simply run these three commands in a Terminal window:
sudo easy_install pip
sudo pip install -U mozregression --ignore-installed
mozregression
A number of Firefox versions will open in succession to narrow down when this started occurring. Simply type "good" or "bad" in Terminal based on whether or not a build reproduces the bug. Once finished, please post the output from the last run. It should give a last good and first bad revision as well as a link to look at the changesets in that range. Thank you!
|
|
||
Comment 7•4 years ago
|
||
This is actually a duplicate of bug 1333781, which covers remapped shortcuts that weren't addressed in bug 429824.
|
||
Comment 8•4 years ago
|
||
(In reply to Simona Badau from comment #3)
At a second view, on the latest Nightly 74.0a1 and Mac OS X 10.14, I'm being able to access the ''Bookmark This Page" option with a remapped preference - I used Cmd+Shift+M, I can't do it though on Firefox 72.0.1.
Tried also to add the remapped Cmd+L shortcut to access the "Bookmark this Page" option, but that didn't work at all, neither on Firefox 72.0.2 nor on the latest Nightly 74.0a1, not sure if it's because this shortcut might already be hardcoded for the "Select Location" or not.
Basically, all the key-combinations used by built-in Firefox shortcuts (such as Cmd+L) cannot be re-assigned other actions via System Preferences, as intended by the OS. Firefox will always perform the built-in action for a built-in key combo.
What does work is assigning key-combinations that are not used by a a built-in Firefox shortcut (such as Cmd+Shift+M) to an action, even if that action already has a built-in key-combination (this is what you observed when assigning Cmd+Shift+M to ''Bookmark This Page").
|
||
Comment 9•4 years ago
|
||
I am experiencing this bug. I'm new to OS X and thus have never seen this working, but I just ran mozregression. The oldest version (from 2009) failed to run due to processor differences, but I tested versions from 2019, 2018, and 2014 and they all exhibited the same behavior: using remapped shortcuts highlights the menu as if they are being activated, but nothing happens.
If this did used to work, perhaps there was a change on OS X's side that broke something?
|
|
||
Comment 10•4 years ago
|
||
We should take further discussion over to bug 1333781.
Description
•