Closed
Bug 1609116
Opened 4 years ago
Closed 4 years ago
Run rustfmt in code review with warnings enabled
Categories
(Developer Infrastructure :: Source Code Analysis, enhancement)
Developer Infrastructure
Source Code Analysis
Tracking
(firefox75 fixed)
RESOLVED
FIXED
mozilla75
| Tracking | Status | |
|---|---|---|
| firefox75 | --- | fixed |
People
(Reporter: bastien, Assigned: bastien)
References
Details
Attachments
(1 file)
The rustfmt mozlint linter only outputs warnings. To display them with the code review bot, we need to run the linter with warnings, but only when CODE_REVIEW=1.
This is a first step towards enabling warnings on all mozlint analyzers when running in code review mode.
|
Assignee | |
Comment 1•4 years ago
|
||
|
||
Comment 2•4 years ago
|
||
There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:bastien, could you have a look please?
For more information, please visit auto_nag documentation.
Flags: needinfo?(bastien)
Pushed by babadie@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a6428fee77a9 Activate warnings for rustfmt on code review mode, r=ahal
|
||
Comment 4•4 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox75:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla75
|
||
Comment 5•4 years ago
|
||
It found an issue here:
https://phabricator.services.mozilla.com/D65621#inline-391460
\o/
|
|
||
Updated•4 years ago
|
Flags: needinfo?(bastien)
|
||
Updated•2 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•