1609196 - [RTL] Arrows are not always pointing in the right direction in the console

Status: VERIFIED FIXED

(DevTools :: Console, defect)

Description

[Itiel]

STR:

1. Set intl.uidirection to 1 and restart
2. Open the console
3. Type console.log(this) and hit enter
4. Observe the expander arrow icon

AR:
Is pointing to the left.

ER:
Should point to the right, as it's like in LTR.

Comment 1

[Itiel]

Attachment: Bug 1609196 - [RTL] Fix the tree arrow icon to point to the right in the webconsole r?jlast

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4a7f4d0ff6cb
[RTL] Fix the tree arrow icon to point to the right in the webconsole r=jlast

Comment 3

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/4a7f4d0ff6cb

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for Beta approval when you get a chance.

Comment 5

[Itiel]

Comment on attachment 9120828 [details]
Bug 1609196 - [RTL] Fix the tree arrow icon to point to the right in the webconsole r?jlast

Beta/Release Uplift Approval Request

• User impact if declined: For RTL users the arrow icon in the webconsole will point to the wrong direction, under some circumstances.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Simple CSS change to mirror the icon specifically in the webconsole for RTL users only
• String changes made/needed: None

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9120828 [details]
Bug 1609196 - [RTL] Fix the tree arrow icon to point to the right in the webconsole r?jlast

Simple CSS fix for an RTL regression. Approved for 73.0b6.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/40fb053c498d7d3954da4fe9caa5152671956e83