Closed Bug 1609196 Opened 4 years ago Closed 4 years ago

[RTL] Arrows are not always pointing in the right direction in the console

Categories

(DevTools :: Console, defect)

Product:
DevTools
Component:
Console
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox-esr68 unaffected, firefox72 unaffected, firefox73 fixed, firefox74 verified)

Status:
VERIFIED FIXED
Milestone:
Firefox 74
Tracking Flags:
Tracking Status
firefox-esr68 --- unaffected
firefox72 --- unaffected
firefox73 --- fixed
firefox74 --- verified

People

(Reporter: itiel_yn8, Assigned: itiel_yn8)

References

(Regression)

Details

(Keywords: regression, rtl)

Attachments

(1 file)

Bug 1609196 - [RTL] Fix the tree arrow icon to point to the right in the webconsole r?jlast
47 bytes, text/x-phabricator-request
RyanVM
: approval-mozilla-beta+
Details | Review

STR:

  1. Set intl.uidirection to 1 and restart
  2. Open the console
  3. Type console.log(this) and hit enter
  4. Observe the expander arrow icon

AR:
Is pointing to the left.

ER:
Should point to the right, as it's like in LTR.

Pushed by dvarga@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4a7f4d0ff6cb
[RTL] Fix the tree arrow icon to point to the right in the webconsole r=jlast

https://hg.mozilla.org/mozilla-central/rev/4a7f4d0ff6cb

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox74: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 74

Please nominate this for Beta approval when you get a chance.

status-firefox72: --- → unaffected
status-firefox73: --- → affected
status-firefox-esr68: --- → unaffected
Flags: needinfo?(itiel_yn8)

Comment on attachment 9120828 [details]
Bug 1609196 - [RTL] Fix the tree arrow icon to point to the right in the webconsole r?jlast

Beta/Release Uplift Approval Request

  • User impact if declined: For RTL users the arrow icon in the webconsole will point to the wrong direction, under some circumstances.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Simple CSS change to mirror the icon specifically in the webconsole for RTL users only
  • String changes made/needed: None
Flags: needinfo?(itiel_yn8)
Attachment #9120828 - Flags: approval-mozilla-beta?
Status: RESOLVED → VERIFIED
status-firefox74: fixed → verified

Comment on attachment 9120828 [details]
Bug 1609196 - [RTL] Fix the tree arrow icon to point to the right in the webconsole r?jlast

Simple CSS fix for an RTL regression. Approved for 73.0b6.

Attachment #9120828 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: