Closed
Bug 1609256
Opened 5 years ago
Closed 5 years ago
Centralize calc() parsing.
Categories
(Core :: CSS Parsing and Computation, task, P3)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla74
| Tracking | Status | |
|---|---|---|
| firefox74 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
References
Details
Attachments
(1 file)
We have a bunch of very similar parsing patterns:
https://searchfox.org/mozilla-central/search?q=%22calc%22&case=false®exp=false&path=servo
We should clean them up a bit now that nll is a thing.
|
Assignee | |
Comment 1•5 years ago
|
||
So that extending it to support other math functions like min / max / etc is
simpler.
There should be no behavior change with this patch, though I added a comment to
some places where we don't do calc() clamping correctly (though other browsers
don't either so...).
|
||
Updated•5 years ago
|
Type: defect → task
Priority: -- → P3
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/65767b6886f5
Centralize calc function parsing. r=boris
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox74:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
You need to log in
before you can comment on or make changes to this bug.
Description
•