1609263 - Android paths are generated with Windows file separators

Status: RESOLVED FIXED

(Testing :: geckodriver, defect, P3)

Description

[Beth Rennie [:beth] (she/her)]

When running Geckodriver on Windows, it will generate paths for the Android device that use the Windows file separator, e.g.:

/data/local/tmp\org.mozilla.geckoview_example-geckoview-config.yaml

This results in operations that will fail.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Thanks for filing! We should indeed fix that for the 0.27 release.

The failing part is here:
https://searchfox.org/mozilla-central/rev/9b4b41b95cbcda63f565bdc24411e15248f91d83/testing/geckodriver/src/android.rs#256-257

Given that push() doesn't offer a custom path separator I would propose we combine those two lines, and directly create the path buf.

Barret, would you be interested to fix that?

Comment 2

[Beth Rennie [:beth] (she/her)]

I'll do that for now, but I think mozdevice should not be accepting a Path for remote paths, since Path is only valid for local paths. I'm going to file a bug to update mozdevice to use nix::NixPath or similar (or &str)

Comment 3

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1609263 - Construct Android paths directly without PathBuf::push r?nalexander

Paths for pushing files to Android devices were being constructed with
PathBuf::push, which uses the system file separator. On Windows, this results
in malformed paths like
/data/local/tmp\org.mozilla.geckoview_example-geckoview-config.yml.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/485e623584d6
Construct Android paths directly without PathBuf::push r=nalexander,webdriver-reviewers,whimboo

Comment 5

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/485e623584d6