1609281 - Loading a mozconfig does not work if there is a unicode environment variable

Status: RESOLVED FIXED

(Firefox Build System :: Mach Core, defect)

Description

[Tom Prince [:tomprince]]

If I try to run any command that tries to load a mozconfig (such as mach python -- --version), when I have a unicode environment variable, I get the following error:

$ TEST_ENV_VAR=$(python3 -c 'print("U{snowman}")') mach python -- --version                                                                                                             
Error loading mozconfig: /Depot/Mozilla/mozilla-central/.mozconfig

Evaluation of your mozconfig exited with an error. This could be triggered
by a command inside your mozconfig failing. Please change your mozconfig
to not error and/or to catch errors in executed commands.

mozconfig output:

------BEGIN_ENV_BEFORE_SOURCE
LESS='-R -M --shift 5'
<....>
Traceback (most recent call last):
  File "/Depot/Mozilla/mozilla-central/python/mozbuild/mozbuild/action/dump_env.py", line 19, in <module>
    print('%s=%s' % (key, quote(value)))
  File "/Depot/Mozilla/mozilla-central/python/mozbuild/mozbuild/action/../shellutil.py", line 210, in quote
    return ' '.join(_quote(s) for s in strings)
  File "/Depot/Mozilla/mozilla-central/python/mozbuild/mozbuild/action/../shellutil.py", line 210, in <genexpr>
    return ' '.join(_quote(s) for s in strings)
  File "/Depot/Mozilla/mozilla-central/python/mozbuild/mozbuild/action/../shellutil.py", line 191, in _quote
    if s and not SHELL_QUOTE_RE.search(s) and not s.startswith('~'):
UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 0: ordinal not in range(128)

Comment 1

[Ricky Stewart]

Attachment: Bug 1609281 - Use the correct encoding when dumping the environment variables in mozconfig

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/933d436bc502
Use the correct encoding when dumping the environment variables in mozconfig r=firefox-build-system-reviewers,froydnj

Comment 3

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/933d436bc502