Closed Bug 1609330 Opened 3 years ago Closed 3 years ago

Height of animation graphs is incorrect

Categories

(DevTools :: Inspector: Animations, defect, P1)

defect

Tracking

(firefox-esr68 unaffected, firefox72 unaffected, firefox73 verified, firefox74 verified)

VERIFIED FIXED
Firefox 74
Tracking Status
firefox-esr68 --- unaffected
firefox72 --- unaffected
firefox73 --- verified
firefox74 --- verified

People

(Reporter: daisuke, Assigned: daisuke)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

Attached image screenshot.png

What were you doing?

  1. Open https://www.mozilla.org/en-US/
  2. Open the animation inspector
  3. Mouse over on "Get a Firefox Account" button.

What happened?

Two CSS Transitions animations are displayed in the animation inspecor.
But the height of both animation graphs are too big.
See the attachment.

Anything else we should know?

This might be regression of bug 1599410.

Pushed by dakatsuka.birchill@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4a72f5821179
Fix the graph height and the location. r=miker
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 74

Please nominate this for Beta approval when you get a chance.

Flags: needinfo?(daisuke)

Thank you for the notice! Yes, I should do that!

Flags: needinfo?(daisuke)

Comment on attachment 9120974 [details]
Bug 1609330: Fix the graph height and the location. r?miker!

Beta/Release Uplift Approval Request

  • User impact if declined: The user might see weird animation graphs.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): This change is only the style of the animation graph and affects the animation inspector only.
  • String changes made/needed:
Attachment #9120974 - Flags: approval-mozilla-beta?

Comment on attachment 9120974 [details]
Bug 1609330: Fix the graph height and the location. r?miker!

Simple fix for an Animation Inspector regression. Approved for 73.0b8.

Attachment #9120974 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
QA Whiteboard: [qa-triaged]

I have reproduced the issue in Nightly v74.0a1 from 2020-01-19 and Beta v73.0b7 and I have verified the fix in Nightly v74.0a1 from 2020-01-21 and Beta v73.0b8 on Windows 10 and Mac OS 10.15.1. The animation is correctly displayed now.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.