1609330 - Height of animation graphs is incorrect

Status: VERIFIED FIXED

(DevTools :: Inspector: Animations, defect, P1)

Description

[Daisuke Akatsuka (:daisuke)]

Attachment: screenshot.png

What were you doing?

1. Open https://www.mozilla.org/en-US/
2. Open the animation inspector
3. Mouse over on "Get a Firefox Account" button.

What happened?

Two CSS Transitions animations are displayed in the animation inspecor.
But the height of both animation graphs are too big.
See the attachment.

Anything else we should know?

This might be regression of bug 1599410.

Comment 1

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1609330: Fix the graph height and the location. r?miker!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4a72f5821179
Fix the graph height and the location. r=miker

Comment 3

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/4a72f5821179

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for Beta approval when you get a chance.

Comment 5

[Daisuke Akatsuka (:daisuke)]

Thank you for the notice! Yes, I should do that!

Comment 6

[Daisuke Akatsuka (:daisuke)]

Comment on attachment 9120974 [details]
Bug 1609330: Fix the graph height and the location. r?miker!

Beta/Release Uplift Approval Request

• User impact if declined: The user might see weird animation graphs.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This change is only the style of the animation graph and affects the animation inspector only.
• String changes made/needed:

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9120974 [details]
Bug 1609330: Fix the graph height and the location. r?miker!

Simple fix for an Animation Inspector regression. Approved for 73.0b8.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/6a9e651e0831

Comment 9

[Daniel Bodea [:danibodea]]

I have reproduced the issue in Nightly v74.0a1 from 2020-01-19 and Beta v73.0b7 and I have verified the fix in Nightly v74.0a1 from 2020-01-21 and Beta v73.0b8 on Windows 10 and Mac OS 10.15.1. The animation is correctly displayed now.