1609407 - key events do not trigger when oninput is also assigned to input

Status: RESOLVED FIXED

(GeckoView :: IME, defect)

Description

[Jan Gregor]

Attachment: index.html

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:72.0) Gecko/20100101 Firefox/72.0

Steps to reproduce:

When typing to input only onInput triggers not key events.

Actual results:

console returns only
oninput

Expected results:

console returns
onkeydown
oninput
onkeyup

Comment 1

[Jan Gregor]

This only happens in Firefox for android. It behaves as expected on Firefox desktop.

Comment 2

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Asking the GV team to triage this one.

Comment 3

[James Willcox (:snorp) ([e-mail]) (he/him)]

Makoto, is this expected?

Comment 4

[Makoto Kato [:m_kato]]

What Keyboard/IME do you use? GBoard?

Comment 5

[Makoto Kato [:m_kato]]

Since intl.ime.hack.on_any_app.fire_key_events_for_composition is true, we will disptach keyboard event....

Comment 6

[Makoto Kato [:m_kato]]

Ah, I may have to turn on intl.ime.hack.on_any_apps.fire_key_events_for_composition for release build.

Comment 7

[Makoto Kato [:m_kato]]

Nakano-san, do you have any concern to turn on intl_ime_hack_on_any_apps_fire_key_events_for_composition on Android release build?

Comment 8

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Hmm, I didn't know it. As far as I tested on Fenix Nightly, the behavior is not so odd. So, it may work better unless web apps do something for Firefox for Android. In strictly speaking, we should have blacklist pref to turn it back off in some domains. However, I guess that it must be really rare web apps to do something only for Firefox for Android due to the share. And fortunately, GeckoView is still preview for next generation Firefox for Android so that I think it's good timing to change it right now.

Comment 9

[Jan Gregor]

(In reply to Makoto Kato [:m_kato] from comment #4)

What Keyboard/IME do you use? GBoard?

I tested this with android(AOSP) keyboard and GBoard

Comment 10

[Makoto Kato [:m_kato]]

(In reply to Masayuki Nakano [:masayuki] (he/him)(JST, +0900) from comment #8)

Hmm, I didn't know it. As far as I tested on Fenix Nightly, the behavior is not so odd. So, it may work better unless web apps do something for Firefox for Android. In strictly speaking, we should have blacklist pref to turn it back off in some domains. However, I guess that it must be really rare web apps to do something only for Firefox for Android due to the share. And fortunately, GeckoView is still preview for next generation Firefox for Android so that I think it's good timing to change it right now.

Chrome dispatches keydown and keyup for this situation with GBoard (although we don't have telemetry data that how many people are GBoard users.) So if there is any issues by dispatching keydown/keyup on mobile web, Chrome will hit same issue.

(In reply to Jan Gregor from comment #9)

(In reply to Makoto Kato [:m_kato] from comment #4)

What Keyboard/IME do you use? GBoard?

I tested this with android(AOSP) keyboard and GBoard

Thanks.

Comment 11

[Makoto Kato [:m_kato]]

Attachment: Bug 1609407 - Turn on intl.ime.hack.on_any_apps.fire_key_events_for_composition for release build.

Some IMEs such as GBoard use IME composition for prediction even if en-us
language. And it won't generate KeyEvent via InputConnection object.
Actually, we can emulate key event for this situation via
intl.ime.hack.on_any_apps.fire_key_events_for_composition, so let's turn on
this preference for release build.

Also, Chrome/Android dispatch key event on prediction, so GeckoView should
dispatch it too.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/30e202fe574a
Turn on intl.ime.hack.on_any_apps.fire_key_events_for_composition for release build. r=masayuki

Comment 13

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/30e202fe574a

Comment 14

[Chris Peterson [:cpeterson]]

Moving some input bugs to the new GeckoView::IME component.

Comment 15

[Chris Peterson [:cpeterson]]

Moving some cursor and key event bugs to the new GeckoView::IME component.