1609482 - Add instrumentation around overflowing the pre-init task queue

Status: RESOLVED FIXED

(Data Platform and Tools :: Glean: SDK, defect, P1)

Description

[Michael Droettboom [:mdroettboom]]

To better identify the cause of bug 1609205, it would be useful to know if we are overrunning the pre-init task queue.

Comment 1

[Michael Droettboom [:mdroettboom]]

Additional requirement: We should report not justif we overflow the queue, but by how many.

Comment 2

[Michael Droettboom [:mdroettboom]]

Attachment: Data review request

Comment 3

[Chris H-C :chutten]

Comment on attachment 9121350 [details]
Data review request

DATA COLLECTION REVIEW RESPONSE:

    Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes. This collection is documented in the Glean SDK's [metrics documentation](https://mozilla.github.io/glean/book/user/collected-metrics/metrics.html).

    Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is controlled by whatever mechanism controls the Glean SDK. For example, in Fenix the UI in the Settings offers this control.

    If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, Michael Droettboom is responsible.


    Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical.

    Is the data collection request for default-on or default-off?

Default on for all channels.

    Does the instrumentation include the addition of any new identifiers?

No.

    Is the data collection covered by the existing Firefox privacy notice?

Yes.

    Does there need to be a check-in in the future to determine whether to renew the data?

No. This collection is permanent.

---
Result: datareview+

Comment 4

[Michael Droettboom [:mdroettboom]]

Attachment: GitHub Pull Request

Comment 5

[Michael Droettboom [:mdroettboom]]

Attachment: GitHub Pull Request

Comment 6

[Alessio Placitelli [:Dexter]]

(In reply to Michael Droettboom [:mdroettboom] from comment #1)

Additional requirement: We should report not justif we overflow the queue, but by how many.

I really wish we had a way to report these overflows through the error stream (we don't, it would be kind of tricky): we could then just have an error "overflowed_init_metric" and have overflowing metric be reported as errors there