1609506 - Extract computation of ComputedFlex{Container,Line,Item}Info into helper methods

Status: RESOLVED FIXED

(Core :: Layout: Flexbox, task, P3)

Description

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

The motivation was to improve the readability by reducing the length of nsFlexContainerFrame::DoFlexLayout, as preparation of further development for flex fragmentation.

Comment 1

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1609506 Part 1 - Extract the creation of ComputedFlexContainerInfo into a helper method.

Comment 2

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1609506 Part 2 - Extract the computation of ComputedFlexContainerInfo's fields into a helper methods.

The order of CreateFlexLineAndFlexItemInfo() and
ComputedFlexContainerInfo() doesn't matter. I call
CreateFlexLineAndFlexItemInfo because it matches the order of the
members in ComputedFlexContainerInfo.

Some comments "... filled out at the end of this function" should be
updated. However, since I'm in the process of refactor these
computations, I'll update them in Part 4.

Depends on D60047

Comment 3

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1609506 Part 3 - Extract the computation of clamp state into a helper method.

Depends on D60048

Comment 4

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1609506 Part 4 - Extract the computation of most fields in ComputedFlexLineInfo and ComputedFlexItemInfo into a helper.

Depends on D60049

Comment 5

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1609506 Part 5 - Move updating clamp state into UpdateFlexLineAndItemInfo().

Depends on D60050

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/32d6d980833c
Part 1 - Extract the creation of ComputedFlexContainerInfo into a helper method. r=bradwerth
https://hg.mozilla.org/integration/autoland/rev/69f7e72facd3
Part 2 - Extract the computation of ComputedFlexContainerInfo's fields into a helper methods. r=bradwerth
https://hg.mozilla.org/integration/autoland/rev/b7bc465a5159
Part 3 - Extract the computation of clamp state into a helper method. r=bradwerth
https://hg.mozilla.org/integration/autoland/rev/3d62a68b0719
Part 4 - Extract the computation of most fields in ComputedFlexLineInfo and ComputedFlexItemInfo into a helper. r=bradwerth
https://hg.mozilla.org/integration/autoland/rev/ade3351d02a6
Part 5 - Move updating clamp state into UpdateFlexLineAndItemInfo(). r=bradwerth

Comment 7

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/32d6d980833c
https://hg.mozilla.org/mozilla-central/rev/69f7e72facd3
https://hg.mozilla.org/mozilla-central/rev/b7bc465a5159
https://hg.mozilla.org/mozilla-central/rev/3d62a68b0719
https://hg.mozilla.org/mozilla-central/rev/ade3351d02a6