Closed
Bug 1609547
Opened 6 years ago
Closed 6 years ago
Underscore after decimal point is wrongly treated as numeric separtor
Categories
(Core :: JavaScript Engine, defect, P3)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla74
Tracking | Status | |
---|---|---|
firefox74 | --- | fixed |
People
(Reporter: arai, Assigned: arai)
Details
Attachments
(1 file)
Testcase:
1._2
Expected result:
throw SyntaxError about identifier _2
starts immediately after numeric literal
Actual Result:
1.2
Assignee | ||
Comment 1•6 years ago
|
||
Pushed by arai_a@mac.com:
https://hg.mozilla.org/integration/autoland/rev/572928224d2d
Do not treat underscode after decimal point a numeric separator. r=jwalden
Comment 3•6 years ago
|
||
Backed out changeset 572928224d2d (Bug 1609547) for causing spidermonkey bustages in numeric-separator-literal-dot-dd-nsl-dd-ep.js CLOSED TREE
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=285156265&repo=autoland&lineNumber=50812
Flags: needinfo?(arai.unmht)
Backout by shindli@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c697754d9059
Backed out changeset 572928224d2d for causing spidermonkey bustages in numeric-separator-literal-dot-dd-nsl-dd-ep.js CLOSED TREE
Assignee | ||
Comment 5•6 years ago
|
||
I overlooked that, when NumericLiteral starts from decimal point, the leading character of DecimalDigits is already consumed before calling decimalNumber
, that breaks the condition for the updated numeric separator.
will post fixed patch after try run.
Flags: needinfo?(arai.unmht)
Comment 6•6 years ago
|
||
Updated•6 years ago
|
Attachment #9121167 -
Attachment description: Bug 1609547 - Do not treat underscode after decimal point a numeric separator. r?jwalden → Bug 1609547 - Do not treat underscore after decimal point a numeric separator. r?jwalden
Pushed by arai_a@mac.com:
https://hg.mozilla.org/integration/autoland/rev/51f6af6a5a78
Do not treat underscore after decimal point a numeric separator. r=jwalden
Comment 8•6 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox74:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
You need to log in
before you can comment on or make changes to this bug.
Description
•