Closed Bug 1609574 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 21211 - Fix valueMissing() for immutable text-mode inputs

Categories

(Core :: DOM: Core & HTML, task, P4)

Product:
Core
Component:
DOM: Core & HTML
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla74
Tracking Flags:
Tracking Status
firefox74 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 21211 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/21211
Details from upstream follow.

Mason Freed <masonfreed@chromium.org> wrote:

Fix valueMissing() for immutable text-mode inputs

Prior to this commit, valueMissing() incorrectly returned true for
text-mode inputs that were readonly or disabled. With this CL, this
situation is fixed.

Fixed: 1039149
Change-Id: I0f3d9b5c00e7c4e9e8fa0a9767119a2ab5d6b01f
Bug: 1039149
Reviewed-on: https://chromium-review.googlesource.com/2003637
WPT-Export-Revision: 291254ccd99c4878c6804a545e0ce34ab1f69753

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 100 subtests

Status Summary

Firefox

OK : 1
PASS: 91
FAIL: 4

Chrome

OK : 1
PASS: 49
FAIL: 46

Safari

OK : 1
PASS: 40
FAIL: 9

Links

GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/html/semantics/forms/constraints/form-validation-validity-valueMissing.html
[INPUT in RADIO status] The checked attribute is false and the name attribute is empty: FAIL

New Tests That Don't Pass

/html/semantics/forms/constraints/form-validation-validity-valueMissing.html
[INPUT in CHECKBOX status] The checked attribute is false: FAIL (Chrome: PASS, Safari: FAIL)
[INPUT in RADIO status] The checked attribute is false and the name attribute is empty: FAIL (Chrome: PASS, Safari: PASS)
[INPUT in RADIO status] The checked attribute is false: FAIL (Chrome: FAIL, Safari: FAIL)
[INPUT in FILE status] The Files attribute is null: FAIL (Chrome: PASS, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1fd3f5028d16
[wpt PR 21211] - Fix valueMissing() for immutable text-mode inputs, a=testonly

https://hg.mozilla.org/mozilla-central/rev/1fd3f5028d16

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox74: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
You need to log in before you can comment on or make changes to this bug.