1609662 - Extend documentation of methods around `Selection::AddRangeAndSelectFramesAndNotifyListeners`

Status: RESOLVED FIXED

(Core :: DOM: Selection, enhancement)

Comment 1

[Mirko Brodesser (:mbrodesser-Igalia)]

Attachment: Bug 1609662: part 1) Add minimal documentation to `Selection::GetRangeAt`. r=smaug

Comment 2

[Mirko Brodesser (:mbrodesser-Igalia)]

Attachment: Bug 1609662: part 2) Refine documentation of `nsTextFrame::SetSelectedRange`. r=emilio

Depends on D60125

Comment 3

[Mirko Brodesser (:mbrodesser-Igalia)]

Attachment: Bug 1609662: part 3) Rename `Selection::AddTableCellRange` to `Selection::MaybeAddTableCellRange`. r=smaug

Depends on D60126

Comment 4

[Mirko Brodesser (:mbrodesser-Igalia)]

Attachment: Bug 1609662: part 4) Move documentation of `Selection::FindInsertionPoint`. r=smaug

Depends on D60127

Comment 5

[Mirko Brodesser (:mbrodesser-Igalia)]

Attachment: Bug 1609662: part 5) Update documentation of `Selection::FindInsertionPoint`. r=smaug

Depends on D60128

Comment 6

[Mirko Brodesser (:mbrodesser-Igalia)]

Attachment: Bug 1609662: part 6) Update documentation of `Selection::GetIndicesForInterval`. r=smaug

Depends on D60129

Comment 7

[Mirko Brodesser (:mbrodesser-Igalia)]

Attachment: Bug 1609662: part 7) Extend documentation of `MaybeAddRangeAndTruncateOverlaps`. r=smaug

Depends on D60130

Comment 8

[Mirko Brodesser (:mbrodesser-Igalia)]

Attachment: Bug 1609662: part 8) Rename `aItem` to `aRange` in `Selection::AddRangesForSelectableNodes`. r=smaug

Depends on D60131

Comment 9

[Mirko Brodesser (:mbrodesser-Igalia)]

Attachment: Bug 1609662: part 9) Update documentation of `Selection::AddRangesForSelectableNodes`. r=smaug

Depends on D60132

Comment 10

[Mirko Brodesser (:mbrodesser-Igalia)]

Attachment: Bug 1609662: part 10) Update documentation of `Selection::MaybeAddTableCellRange`. r=smaug

Depends on D60133

Comment 11

[Mirko Brodesser (:mbrodesser-Igalia)]

Attachment: Bug 1609662: part 11) Rename `nsTextFrame::SetSelectedRange` and add `nsIFrame::SelectionStateChanged`. r=emilio,smaug

Comment 12

[Mirko Brodesser (:mbrodesser-Igalia)]

Attachment: Bug 1609662: part 12) Replace unreachable code with assertions in `Selection::AddRangeAndSelectFramesAndNotifyListeners`. r=smaug

Comment 13

[Mirko Brodesser (:mbrodesser-Igalia)]

Attachment: Bug 1609662: part 13) Declare some methods in `Selection` const. r=smaug

Comment 14

[Mirko Brodesser (:mbrodesser-Igalia)]

Attachment: Bug 1609662: part 14) Document some `ContentIterator*` methods. r=smaug

Depends on D60254

Comment 15

[Mirko Brodesser (:mbrodesser-Igalia)]

Attachment: Bug 1609662: part 15) Rename some methods in `Selection`. r=smaug

Depends on D60255

Comment 16

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/93872cc53f35
https://hg.mozilla.org/mozilla-central/rev/4dab2c3a9eed
https://hg.mozilla.org/mozilla-central/rev/7fcd6871a9d1
https://hg.mozilla.org/mozilla-central/rev/bf748d5c0292
https://hg.mozilla.org/mozilla-central/rev/0c06c2fc38df
https://hg.mozilla.org/mozilla-central/rev/ac2d07bfc717
https://hg.mozilla.org/mozilla-central/rev/72d1ef79cd79
https://hg.mozilla.org/mozilla-central/rev/3076905f2ddb
https://hg.mozilla.org/mozilla-central/rev/73456f27d2c4
https://hg.mozilla.org/mozilla-central/rev/117454131940

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cea460da5fa6
part 11) Rename `nsTextFrame::SetSelectedRange` and add `nsIFrame::SelectionStateChanged`. r=emilio,smaug
https://hg.mozilla.org/integration/autoland/rev/eb9ef69f5f8d
part 12) Replace unreachable code with assertions in `Selection::AddRangeAndSelectFramesAndNotifyListeners`. r=smaug
https://hg.mozilla.org/integration/autoland/rev/cccd16c77d8d
part 13) Declare some methods in `Selection` const. r=smaug
https://hg.mozilla.org/integration/autoland/rev/5be8caac475d
part 14) Document some `ContentIterator*` methods. r=smaug
https://hg.mozilla.org/integration/autoland/rev/b15a25d7dd9a
part 15) Rename some methods in `Selection`. r=smaug

Comment 18

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/cea460da5fa6
https://hg.mozilla.org/mozilla-central/rev/eb9ef69f5f8d
https://hg.mozilla.org/mozilla-central/rev/cccd16c77d8d
https://hg.mozilla.org/mozilla-central/rev/5be8caac475d
https://hg.mozilla.org/mozilla-central/rev/b15a25d7dd9a

Comment 19

[Mirko Brodesser (:mbrodesser-Igalia)]

Attachment: Bug 1609662: part 16) Move `nsRange::IsNodeSelected` to `nsINode::IsSelected`. r=smaug

Make it const-correct too.

Comment 20

[Mirko Brodesser (:mbrodesser-Igalia)]

Attachment: Bug 1609662: part 17) Clean up some code around Selection and ranges in `nsDocumentEncoder`. r=smaug

Depends on D60643

Comment 21

[Mirko Brodesser (:mbrodesser-Igalia)]

Attachment: Bug 1609662: part 18) Remove `RangeMatchesBeginPoint` function in Selection. r=smaug

The name was misleading.

Comment 22

[Mirko Brodesser (:mbrodesser-Igalia)]

Attachment: Bug 1609662: part 19) Change `Selection::EqualsRangeAtPoint` to `HasEqualRangeBoundariesAt`. r=smaug

Depends on D60949

Comment 23

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9c197c372d9e
part 18) Remove `RangeMatchesBeginPoint` function in Selection.  r=smaug

Comment 24

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d0f7ca95c02f
part 19) Change `Selection::EqualsRangeAtPoint` to `HasEqualRangeBoundariesAt`. r=smaug

Comment 25

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/9c197c372d9e
https://hg.mozilla.org/mozilla-central/rev/d0f7ca95c02f

Comment 26

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e38b8297b063
part 16) Move `nsRange::IsNodeSelected` to `nsINode::IsSelected`. r=smaug
https://hg.mozilla.org/integration/autoland/rev/ade06f6e4d27
part 17) Clean up some code around Selection and ranges in `nsDocumentEncoder`. r=smaug

Comment 27

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/e38b8297b063
https://hg.mozilla.org/mozilla-central/rev/ade06f6e4d27