1609767 - Remove server code from Screenshots

Status: RESOLVED DUPLICATE of bug 1612982

(Firefox :: Screenshots, task)

Description

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

We are in the process of shutting down the Screenshots server.

Seems like a good time to coordinate about how to handle removing code in Firefox that interacts with the server.

Ian has a WIP branch with a checklist over in Github: https://github.com/mozilla-services/screenshots/pull/5374

I'm not sure how relevant that issue's checklist is, or how much it'll conflict with the patches in bug 1587544, but it's a starting point.

Paging :aswan and :ianb to discuss further in this bug and document a plan.

Comment 1

[Andrew Swan [:aswan]]

Whew, there's a lot of stuff on that branch. From a brief glance, it looks like most of the changes to the extension consist of removing chunks of code so even if there are conflicts that can't be automatically resolved, it appears to me that they should be straightforward to resolve manually. I don't really have any idea about the existing checklist and how up-to-date it is...

I thought somebody told me (though I can't find where at the moment) that the github repository was considered deprecated and mozilla-central was the place where any future work on screenshots would take place. If its easier to do this work in the github repo and then export the extension and resolve conflicts, I can try to help with that last step, though that sounds tedious if this takes more than one or two iterations.

Comment 2

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

I thought somebody told me (though I can't find where at the moment) that the github repository was considered deprecated and mozilla-central was the place where any future work on screenshots would take place.

Yeah, I think we discussed that in a bug or over email. I didn't remember how to do the exports from github into m-c, and some upstream refactorings have landed over the past year or whatever that may not have been tracked with bugs on the github side. Seems best to just work from m-c and ignore github.

I'm going to dupe this to bug 1612982, which I filed after forgetting I'd filed this. The new bug has the checklist in it, seems more useful as a starting point.