1609859 - Stop throwing incorrect exceptions from PeerConnection

Status: RESOLVED FIXED

(Core :: WebRTC, defect, P2)

Description

[Boris Zbarsky [:bzbarsky]]

We're throwing DOMExceptions named "TypeError" instead of actual TypeErrors.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1609859. Stop throwing incorrect exceptions from PeerConnection.

We're throwing DOMExceptions named 'TypeError' instead of actual TypeErrors.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/005ecbc6f1f9
Stop throwing incorrect exceptions from PeerConnection. r=jib

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Failed to create upstream wpt PR due to merge conflicts. This requires fixup from a wpt sync admin.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Hmm. The file in our tree looks quite different from the one upstream... James, any idea what's going on here?

Comment 5

[Boris Zbarsky [:bzbarsky]]

And I can, of course, manually try merging the two and pushing it both to our tree and upstream.....

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/005ecbc6f1f9

Comment 7

[James Graham [:jgraham]]

The answer appears to be that the merge conflict between bug 1531904 and https://github.com/web-platform-tests/wpt/pull/16038 was incorrectly resolved, even though I apparently realised there was a problem and reached out for a correct fix. So yeah, at this point I think pushing patches as required to resolve the situation is probably the right way forward. Sorry about this.

Comment 8

[Boris Zbarsky [:bzbarsky]]

Aha, thank you for that pointer. I filed bug 1610422 to track the Gecko-side changes to resolve the conflict.