1609860 - Redesign AutoStyleCacheArray

Status: RESOLVED FIXED

(Core :: DOM: Editor, enhancement, P3)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

AutoStyleCacheArray creates 19 StyleCache instances from constructor. StyleCache has nsString member variable and most of the nsString instance are not used in most cases. Therefore, we should make it create StyleCache instance when it's necessary.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1609860 - Make `AutoStyleCacheArray` cache only applied styles r=m_kato!

Currently, AutoStyleCacheArray has style information of all 19 styles.
However, its element type, StyleCache has nsString instance. Therefore,
the initializing cost is not reasonable since in most cases most of the
StyleCache instances are not used actually.

This patch makes HTMLEditor::GetInlineStyles() append elements only for
applied styles and HTMLEditor::ReapplyCachedStyles() look for current
value from an instance with new IndexOf() method. Therefore, this patch
may make slower if a lot of styles are applied. However, we can expect that
it's rare case.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6d5b9108896d
Make `AutoStyleCacheArray` cache only applied styles r=m_kato

Comment 3

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/6d5b9108896d