1609861 - Stop using NS_ERROR_DOM_TYPE_ERR in mediasource

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Boris Zbarsky [:bzbarsky]]

It causes us to throw the wrong sort of exception.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1609861 part 1. Stop using NS_ERROR_DOM_TYPE_ERR in MediaSource::SetLiveSeekableRange. r=jya

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1609861 part 2. Stop using NS_ERROR_DOM_TYPE_ERR in SourceBuffer::ChangeType. r=jya

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1609861 part 3. Stop using NS_ERROR_DOM_TYPE_ERR in SourceBuffer::PrepareRemove r=jya

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1609861 part 4. Stop using NS_ERROR_DOM_TYPE_ERR in appendWindowStart/End setters. r=jya

Comment 5

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1609861 part 5. Stop using NS_ERROR_DOM_TYPE_ERR in IsTypeSupported. r=jya

Comment 6

[Boris Zbarsky [:bzbarsky]]

To clarify what's going on here: whenever you throw an nsresult value on an ErrorResult you will get an Exception or DOMException thrown, not a JS Error. So this code was throwing DOMExceptions with the name set to TypeError, not actual JS TypeError objects.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a739f7e78871
part 1.  Stop using NS_ERROR_DOM_TYPE_ERR in MediaSource::SetLiveSeekableRange. r=jya
https://hg.mozilla.org/integration/autoland/rev/2f0bfb1d550c
part 2.  Stop using NS_ERROR_DOM_TYPE_ERR in SourceBuffer::ChangeType.  r=jya
https://hg.mozilla.org/integration/autoland/rev/d6e3926d4f1f
part 3.  Stop using NS_ERROR_DOM_TYPE_ERR in SourceBuffer::PrepareRemove  r=jya
https://hg.mozilla.org/integration/autoland/rev/fea0bcc359a4
part 4.  Stop using NS_ERROR_DOM_TYPE_ERR in appendWindowStart/End setters.  r=jya
https://hg.mozilla.org/integration/autoland/rev/033d0e4500d9
part 5.  Stop using NS_ERROR_DOM_TYPE_ERR in IsTypeSupported.  r=jya

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/21237 for changes under testing/web-platform/tests

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 10

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/a739f7e78871
https://hg.mozilla.org/mozilla-central/rev/2f0bfb1d550c
https://hg.mozilla.org/mozilla-central/rev/d6e3926d4f1f
https://hg.mozilla.org/mozilla-central/rev/fea0bcc359a4
https://hg.mozilla.org/mozilla-central/rev/033d0e4500d9

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot