1609881 - Put the fork server behind a preference so we have a simple way to enable it

Status: RESOLVED FIXED

(Core :: IPC, task)

Description

[Gabriele Svelto [:gsvelto]]

As per the title. The plan is to enable the fork server in builds while keeping it off at runtime with this pref; then when we're sure we have fully stabilized it we'll turn it on by default.

Comment 1

[Thinker Li [:sinker]]

Attachment: Bug 1609881 - Part 1: put the fork server behind a preference. r=gsvelto

Comment 2

[Thinker Li [:sinker]]

Attachment: Bug 1609881 - Part 3: build the fork server for Linux & FreeBSD. r=gsvelto

Comment 3

[Mike Hommey [:glandium]]

While you're there, could you move the configure flag in toolkit/moz.configure?

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a6060b962c80
Part 1: put the fork server behind a preference. r=gsvelto

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/84184c894e33
Part 2: build the fork server for Linux & FreeBSD. r=gsvelto

Comment 6

[Andreea Pavel [:apavel]]

Backed out part2 for multiple failures e.g assertion failures, leaks

Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=84184c894e33a8711d1f5b0013619eb7714bda7b&selectedJob=288570815

Failure log:

• assertion: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=288570815&repo=autoland&lineNumber=1400
• leak: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=288570809&repo=autoland&lineNumber=4446
• python mozbuild: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=288570809&repo=autoland&lineNumber=4446

Backout: https://hg.mozilla.org/integration/autoland/rev/584f0d57a0efe35658674d0e8d23f27a11114ae1

Comment 7

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/a6060b962c80

Comment 8

[Thinker Li [:sinker]]

Attachment: Bug 1609881 - Part 2: Move fork server launcher to app-startup. r=gsvelto

Move fork server launcher to app-startup instead of xpcom-startup.

Comment 9

[Thinker Li [:sinker]]

Attachment: Bug 1609881 - Part 2: Move fork server launcher to final-ui-startup. r=gsvelto

Accessing StaticPrefs at xpcom-startup is too early to cause the
initialization of it. The preferences from user.js and profile are
not load yet. So, later, it would cause error of changing the value
of static prefs that is marked as mirroring once.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/19b4dadd16f4
Part 2: Move fork server launcher to final-ui-startup. r=gsvelto
https://hg.mozilla.org/integration/autoland/rev/638974f6efd0
Part 3: build the fork server for Linux & FreeBSD. r=gsvelto

Comment 11

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/19b4dadd16f4
https://hg.mozilla.org/mozilla-central/rev/638974f6efd0

Comment 12

[Thinker Li [:sinker]]

clear ni