1609943 - Clean up C++ coding style document

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, task)

Description

[Simon Giesecke [:sg] [he/him]]

After the C++ coding style document moved in-tree, some cleanup should be done on it. This bug covers only such cleanup that doesn't change the semantics, but only formatting, structural and related issues.

Comment 1

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1609943 - Cleanup in-line code fragments to use proper encapsulation. r=sylvestre

Comment 2

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1609943 - Split guideline on unary operators into C++ and JavaScript part. r=sylvestre

Depends on D60260

Comment 3

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1609943 - Move mode line section from C++ to general coding style. r=sylvestre

Depends on D60261

Comment 4

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1609943 - Refer to UpperCamelCase to remove ambiguity. r=sylvestre

Depends on D60262

Comment 5

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1609943 - Move all string-related rules into one section. r=sylvestre

Depends on D60263

Comment 6

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1609943 - Move static analysis to its own section, and add notes on a few more clang-tidy checks. r=sylvestre

Depends on D60264

Comment 7

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1609943 - Merged two mentions of naming nsresult error variables, and improved wording a bit. r=sylvestre

Depends on D60273

Comment 8

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1609943 - Improved section on comparison against true/false, and added note on clang-tidy check. r=sylvestre

Depends on D60281

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3cac9afcff10
Cleanup in-line code fragments to use proper encapsulation. r=sylvestre
https://hg.mozilla.org/integration/autoland/rev/50891b17f48a
Split guideline on unary operators into C++ and JavaScript part. r=sylvestre
https://hg.mozilla.org/integration/autoland/rev/9f0f1500f848
Move mode line section from C++ to general coding style. r=sylvestre
https://hg.mozilla.org/integration/autoland/rev/9e11adb8e96e
Refer to UpperCamelCase to remove ambiguity. r=sylvestre
https://hg.mozilla.org/integration/autoland/rev/5717a944bd12
Move all string-related rules into one section. r=sylvestre
https://hg.mozilla.org/integration/autoland/rev/9fbbcbab8bc7
Move static analysis to its own section, and add notes on a few more clang-tidy checks. r=sylvestre
https://hg.mozilla.org/integration/autoland/rev/0221af408c1a
Merged two mentions of naming nsresult error variables, and improved wording a bit. r=sylvestre
https://hg.mozilla.org/integration/autoland/rev/876e928aad40
Improved section on comparison against true/false, and added note on clang-tidy check. r=sylvestre

Comment 10

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/3cac9afcff10
https://hg.mozilla.org/mozilla-central/rev/50891b17f48a
https://hg.mozilla.org/mozilla-central/rev/9f0f1500f848
https://hg.mozilla.org/mozilla-central/rev/9e11adb8e96e
https://hg.mozilla.org/mozilla-central/rev/5717a944bd12
https://hg.mozilla.org/mozilla-central/rev/9fbbcbab8bc7
https://hg.mozilla.org/mozilla-central/rev/0221af408c1a
https://hg.mozilla.org/mozilla-central/rev/876e928aad40