1610066 - SafeElementAt on nsTArray<RefPtr<T>> requires complete type T.

Status: RESOLVED FIXED

(Core :: XPCOM, task)

Description

[Emilio Cobos Álvarez (:emilio)]

Which makes us have a ton of silly includes.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

TLDR this doesn't compile:

struct RefCounted;

class Foo {
  ~Foo(); // Intentionally out of line

  nsTArray<RefPtr<RefCounted>> mArray;

  RefCounted* GetFirst() const {
    return mArray.SafeElementAt(0);
  }
};

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1610066 - Make nsTArray::SafeElementAt not require the complete type for smart pointers. r=froydnj

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8c0a314f916f
Make nsTArray::SafeElementAt not require the complete type for smart pointers. r=froydnj

Comment 4

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/8c0a314f916f