1610152 - LastPass extension panel appears empty when pinned to overflow menu

Status: VERIFIED FIXED

(Core :: Layout, defect)

Description

[Kestrel]

Attachment: Comparison showing LastPass panel pinned to overflow menu now appearing empty

STR:

1. Install LastPass extension.
2. Pin toolbar icon to overflow menu.
3. Open extension in overflow menu.

Before the regression the panel was too small but rendered some text, after the regression the panel is blank.

Regresssion range:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=5e6b050c9427da9ae37ca4c7c8000ba5b47ceea8&tochange=1a85c571a4645798ba4d9295ba2504acac149ac8

Regressed by Bug 1576946.

Comment 1

[Tim Nguyen :ntim]

style="height: 0px is being set on the browser, but the stack has a min-height of ~400px. min-height: 100% on the browser should force it to take at least the min-height of the stack.

Comment 2

[Tim Nguyen :ntim]

Attachment: Bug 1610152 - Ensure extension browsers take at least their parent's min-height. r=Gijs

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e29693ba69fc
Ensure extension browsers take at least their parent's min-height. r=Gijs

Comment 4

[Tim Nguyen :ntim]

Comment on attachment 9121755 [details]
Bug 1610152 - Ensure extension browsers take at least their parent's min-height. r=Gijs

Beta/Release Uplift Approval Request

• User impact if declined: Some extension panels become unusable in overflow menu
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See comment 0, contents of the extension panel should not be blank
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Quick one-line straightforward CSS fix
• String changes made/needed: none

Comment 5

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/e29693ba69fc

Comment 6

[Raluca Popovici, Desktop QA]

Attachment: 2020-01-21_14h25_33.png

Comment 7

[Raluca Popovici, Desktop QA]

Still occurs on my end, If I click multiple times on Last Pass and the Back arrow the Addon window gets smaller. In the screenshot from the description I saw the exact same issue. Can someone verify this issue and let us know if its intended behavior ? Please see the attached screenshot.

Comment 8

[Tim Nguyen :ntim]

(In reply to Raluca from comment #7)

Still occurs on my end, If I click multiple times on Last Pass and the Back arrow the Addon window gets smaller. In the screenshot from the description I saw the exact same issue. Can someone verify this issue and let us know if its intended behavior ? Please see the attached screenshot.

This is only supposed to fix the fact that the panel is blank ("after" screenshot). After the fix, it's supposed to look like the "before" screenshot.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9121755 [details]
Bug 1610152 - Ensure extension browsers take at least their parent's min-height. r=Gijs

Simple CSS fix for a panel sizing regression. Approved for 73.0b8.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/ba2d89bc5efc

Comment 11

[Raluca Popovici, Desktop QA]

Verified-fixed on latest Nightly 74.0a1 and Beta 73.0b8 using Windows 10, Mac OS 10.15.1 and Ubuntu 18.04.