1610158 - Crash in [@ mozilla::dom::MediaController::~MediaController]

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P1)

Description

[[:philipp]]

This bug is for crash report bp-012b9fb0-c22a-435a-99e2-937150200118.

Top 10 frames of crashing thread:

0 xul.dll mozilla::dom::MediaController::~MediaController dom/media/mediacontrol/MediaController.cpp:33
1 xul.dll mozilla::dom::MediaControlService::ControllerManager::~ControllerManager dom/media/mediacontrol/MediaControlService.h:87
2 xul.dll mozilla::dom::MediaControlService::~MediaControlService dom/media/mediacontrol/MediaControlService.cpp:75
3 xul.dll mozilla::dom::MediaControlService::Release dom/media/mediacontrol/MediaControlService.cpp:53
4 xul.dll nsCOMArray_base::~nsCOMArray_base xpcom/ds/nsCOMArray.cpp:51
5 xul.dll nsObserverList::NotifyObservers xpcom/ds/nsObserverList.cpp:67
6 xul.dll nsObserverService::NotifyObservers xpcom/ds/nsObserverService.cpp:291
7 xul.dll mozilla::ShutdownXPCOM xpcom/build/XPCOMInit.cpp:617
8 xul.dll ScopedXPCOMStartup::~ScopedXPCOMStartup toolkit/xre/nsAppRunner.cpp:1230
9 xul.dll XREMain::XRE_main toolkit/xre/nsAppRunner.cpp:4769

this crash signature is appearing in 74.0a1 since build 20200117094453 with
MOZ_DIAGNOSTIC_ASSERT(!mIsRegisteredToService).

Comment 1

[Pascal Chevrel:pascalc]

Alastor, the volume of crashes is a bit on the high side for nightly, could you investigate please? Thanks

I am setting the bug as P1 so as that we don't loose track of it before the beta merge, I'd like not to get into the beta cycle with this crasher. If this is a crash that would only happen on nightly, feel free to reprioritize.

Comment 2

[Alastor Wu [:alwu]]

Attachment: Bug 1610158 - ensure we have called controller's shutdown before it gets destroyed.

Ensure we have called controller's shutdown before it gets destroyed and not to change its internal status after shutdown.

Comment 3

[Alastor Wu [:alwu]]

Have pushed my patch to the try server, and set leave-open to manually close this bug after ensuring the crash has been fixed.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=12ddf21d4e6a546f0aa40e23c56ccfaab1558886

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a4ab563e998c
ensure we have called controller's shutdown before it gets destroyed. r=chunmin

Comment 5

[Noemi Erli[:noemi_erli]]

Backed out changeset a4ab563e998c (Bug 1610158) for causing failures in MediaController.cpp

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=285870444&resultStatus=pending%2Crunning%2Ctestfailed%2Cbusted%2Cexception&revision=a4ab563e998c335c926e7a815289ec1a0ee88ffa

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=285868684&repo=autoland&lineNumber=26404

Backout: https://hg.mozilla.org/integration/autoland/rev/aa7246c19de438ef05c4244d82d5f54d11f4c1e6

Comment 6

[Alastor Wu [:alwu]]

Add gtest this time
https://treeherder.mozilla.org/#/jobs?repo=try&revision=2643bf9daeb7c75005a6c5f209d7cc6735133058

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/27b667ab2923
ensure we have called controller's shutdown before it gets destroyed. r=chunmin

Comment 8

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/27b667ab2923

Comment 9

[Alastor Wu [:alwu]]

There is no any crash happening on the version which build date is after 1/21, so we can close this bug.