1610165 - SVG images that fail to get inserted into the cache get stuck in a repaint loop

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Emilio Cobos Álvarez (:emilio)]

Playing a bit with the cache params to investigate bug 1609672, I noticed via logging that we always repaint SVGs that fail to get inserted into the cache.

Fix seems trivial.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1610165 - Failing to insert an SVG into the surface cache continuously repaints the image. r=aosmond,tnikkel

I was poking at the missing images bug by dropping cache sizes and such and
found that we always ended up repainting some SVGs over and over. This seems to
be the cause. When we fail to insert into the cache we still end up notifying
over and over (because we forget to say aWillCache=false), so we'd end up
repainting, and failing again, etc.

This is easy to see adding some logging to
nsDisplayBackgroundImage::PaintInternal.

Any ideas as to how to add a test for it?

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/206cec28723a
Failing to insert an SVG into the surface cache continuously repaints the image. r=tnikkel

Comment 3

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/206cec28723a