Closed Bug 1610221 Opened 4 years ago Closed 4 years ago

Missing “Picture in picture” functionality on some videos.

Categories

(Toolkit :: Video/Audio Controls, defect)

74 Branch
Unspecified
Windows 10
defect
Not set
normal

Tracking

()

RESOLVED INVALID

People

(Reporter: karlcow, Unassigned)

References

(Blocks 1 open bug, )

Details

  1. Go to the two URIs below.
  2. See the difference for the PiP toggle

PiP visible

In the case of https://www.instagram.com/tv/B7WF3NihKEB/ @softvision-oana-arbuzov upload.

The markup is

<div class="_5wCQW">
    <video class="tWeCl"
           controls=""
           controlslist="nodownload"
           playsinline=""
           poster="https://scontent-nrt1-1.cdninstagram.com/v/t51.2885-15/e15/79152842_2493140317574122_2084007959398797004_n.jpg?_nc_ht=scontent-nrt1-1.cdninstagram.com&amp;_nc_cat=110&amp;_nc_ohc=Iwqn-LlBX30AX9Vz5dr&amp;oh=f1b7935a593092b0f50412731a123718&amp;oe=5E272A41"
           preload="metadata"
           type="video/mp4"
           src="https://scontent-nrt1-1.cdninstagram.com/v/t50.16885-16/83640571_216167026071778_1882380845372439027_n.mp4?_nc_ht=scontent-nrt1-1.cdninstagram.com&amp;_nc_cat=110&amp;_nc_ohc=cmVbnn6gHhEAX_dXOca&amp;oe=5E275FDC&amp;oh=57604779f3f0b91ec81afecd1c9d4b50"></video>
</div>

PiP not visible

In the case of the bug report https://www.instagram.com/tv/BxtFyfdny30/

<div class="_5wCQW">
    <video class="tWeCl"
           controls=""
           controlslist="nodownload"
           playsinline=""
           poster="https://scontent-nrt1-1.cdninstagram.com/v/t51.2885-15/e35/61075973_130735091445437_6110959679057728065_n.jpg?_nc_ht=scontent-nrt1-1.cdninstagram.com&amp;_nc_cat=105&amp;_nc_ohc=_bbjqdyi7A4AX--WEPH&amp;oh=ed5a50321659c3920075553ef65eb277&amp;oe=5E275C5F"
           preload="metadata"
           type="video/mp4"
           src="https://scontent-nrt1-1.cdninstagram.com/v/t50.16885-16/61013284_322495501765020_1299667579194834944_n.mp4?_nc_ht=scontent-nrt1-1.cdninstagram.com&amp;_nc_cat=100&amp;_nc_ohc=LSlrud58fcAAX_fVBgC&amp;oe=5E2743AE&amp;oh=02aa332c3a672b355ce6d938e813822b"></video>
</div>

Mike, could you look at this?

Flags: needinfo?(mconley)

Hi karlcow,

This is intentional. We use a set of heuristics to determine when to show the toggle to avoid showing it when it might be annoying (see bug 1547795). Specifically, we don't show the toggle if:

  1. The video is shorter than 45s long
  2. The video has no audio
  3. Either the width or the height of the video is less than 160px

In the case of your second video, it's less than 45s long, which is why we're not showing the toggle.

There's a preference to always show the toggle (media.videocontrols.picture-in-picture.video-toggle.always-show) that you can set to true if you'd like, and then we'll try to show the toggle on all videos, regardless of their length, size, or audio type.

Status: NEW → RESOLVED
Closed: 4 years ago
Flags: needinfo?(mconley)
Resolution: --- → INVALID
Component: Audio/Video → Video/Audio Controls
Product: Core → Toolkit
You need to log in before you can comment on or make changes to this bug.