1610250 - Zoom level badge is displayed in the address bar for default zoom level set to 110%

Status: VERIFIED FIXED

(Firefox :: Disability Access, defect, P3)

Description

[Alin Ilea, Desktop Test Engineering]

Affected versions:

Nightly 74.0a1 (2020-01-20), Beta 73.0b7

Affected platforms:

ALL

Steps:

1. Launch Firefox with a new profile and go to about:preferences.
2. Under General, go to Zoom section and select 110% value from the "Default zoom" dropdown.

Actual result:

The zoom level badge is displayed next to the url bar.

Expected result:

The zoom level badge should be not displayed in the URL bar for default zoom level. It is displayed only when the default zoom is set to 110%. For any other value the badge is not displayed.

Comment 1

[:Gijs (out for now; he/him)]

I'm guessing this is courtesy of double-precision floating value rounding...

Comment 2

[Morgan Reschenberg [:morgan]]

Attachment: gross-floating-point-rounding.png

:gijs you win a prize!

Comment 3

[Morgan Reschenberg [:morgan]]

Attachment: Bug 1610250: Ensure we compare rounded integer values when setting the hidden attribute of the URL bar's zoom button. r?gijs

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f3356585ca13
Ensure we compare rounded integer values when setting the hidden attribute of the URL bar's zoom button. r=Gijs

Comment 5

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/f3356585ca13

Comment 6

[:Gijs (out for now; he/him)]

This seems like a safe fix, want to request uplift for 73?

Comment 7

[Alin Ilea, Desktop Test Engineering]

Verified - Fixed in latest Nightly build 74.0a1 (Build id: 20200122094859) using Windows 10, Mac OS 10.15 and Ubuntu 18.04

Comment 8

[Morgan Reschenberg [:morgan]]

yep will do :)

Comment 9

[Morgan Reschenberg [:morgan]]

Comment on attachment 9122088 [details]
Bug 1610250: Ensure we compare rounded integer values when setting the hidden attribute of the URL bar's zoom button. r?gijs

Beta/Release Uplift Approval Request

• User impact if declined: Users will see inaccurate behavior in the URL bar; the zoom percentage will remain visible even when the page is scaled to the default zoom level set in preferences.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This patch contains a one line change which involves adding a rounding statement.
• String changes made/needed: N/A

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9122088 [details]
Bug 1610250: Ensure we compare rounded integer values when setting the hidden attribute of the URL bar's zoom button. r?gijs

shakes his fist at floating point Approved for 73.0b9.

Comment 11

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/releases/mozilla-beta/rev/ad0b96ec1b63

Comment 12

[Alin Ilea, Desktop Test Engineering]

Verified - Fixed in latest Beta 73.0b9 (Build id: 20200122212931). I will mark the flags accordingly.
Thanks.