Closed Bug 1610297 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 21264 - webrtc: Implement and ship RTCRtpEncodingParameters.maxFramerate

Categories

(Core :: WebRTC, task, P4)

Product:
Core
Component:
WebRTC
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla74
Tracking Flags:
Tracking Status
firefox74 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 21264 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/21264
Details from upstream follow.

Florent Castelli <orphis@chromium.org> wrote:

webrtc: Implement and ship RTCRtpEncodingParameters.maxFramerate

Intent: https://groups.google.com/a/chromium.org/g/blink-dev/c/SV8evGSU_dw/m/DIrx9XzvDQAJ

Bug: 1043655
Change-Id: I340ad755fe4a33c566a4374e1f45bc9014f5e2d7
Reviewed-on: https://chromium-review.googlesource.com/2010845
WPT-Export-Revision: 5ae5ae170d107f3ccd86276ac79678a47e190738

PR 21264 applied with additional changes from upstream: ea0c61366e7fc36aec3ad69c007989bf1d3b8b2d
Component: web-platform-tests → WebRTC
Product: Testing → Core

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 50 tests

Status Summary

Firefox

OK : 2[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-asan-opt, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] 9[GitHub]
PASS: 41
FAIL: 6[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-asan-opt, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] 43[GitHub]

Chrome

OK : 9
PASS: 36
FAIL: 7

Safari

OK : 9
FAIL: 43

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/webrtc/RTCRtpParameters-headerExtensions.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-asan-opt, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)
setParameters() with modified headerExtensions should reject with InvalidModificationError: FAIL (Chrome: PASS, Safari: FAIL)
/webrtc/RTCRtpParameters-codecs.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-asan-opt, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)
setParameters() with codec.mimeType modified should reject with InvalidModificationError: FAIL (Chrome: PASS, Safari: FAIL)
setParameters() with new codecs inserted should reject with InvalidModificationError: FAIL (Chrome: PASS, Safari: FAIL)
setParameters() with codec.clockRate modified should reject with InvalidModificationError: FAIL (Chrome: PASS, Safari: FAIL)
setParameters() with codec.channels modified should reject with InvalidModificationError: FAIL (Chrome: PASS, Safari: FAIL)
setParameters() with codec.payloadType modified should reject with InvalidModificationError: FAIL (Chrome: PASS, Safari: FAIL)
setParameters() with codec.sdpFmtpLine modified should reject with InvalidModificationError: FAIL (Chrome: PASS, Safari: FAIL)
/webrtc-extensions/RTCRtpParameters-maxFramerate.html
setParameters() with modified encoding.maxFramerate should succeed with RTCRtpTransceiverInit: FAIL (Chrome: FAIL, Safari: FAIL)
addTransceiver() with sendEncoding.maxFramerate field set to less than 0 should reject with RangeError: FAIL (Chrome: FAIL, Safari: FAIL)
setParameters() with encoding.maxFramerate field set to less than 0 should reject with RangeError: FAIL (Chrome: FAIL, Safari: FAIL)
setParameters() with modified encoding.maxFramerate should succeed without RTCRtpTransceiverInit: FAIL (Chrome: FAIL, Safari: FAIL)
/webrtc/RTCRtpParameters-transactionId.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-asan-opt, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)
sender.setParameters() with transaction ID different from last getParameters() should reject with InvalidModificationError: FAIL (Chrome: PASS, Safari: FAIL)
setParameters() with parameters older than last getParameters() should reject with InvalidModificationError: FAIL (Chrome: PASS, Safari: FAIL)
sender.getParameters() should return different transaction IDs for each call: FAIL (Chrome: PASS, Safari: FAIL)
sender.setParameters() with transaction ID unset should reject with TypeError: FAIL (Chrome: PASS, Safari: FAIL)
setParameters() twice with the same parameters should reject with InvalidStateError: FAIL (Chrome: PASS, Safari: FAIL)
/webrtc/RTCRtpParameters-rtcp.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-asan-opt, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)
setParameters() with modified rtcp.cname should reject with InvalidModificationError: FAIL (Chrome: PASS, Safari: FAIL)
setParameters() with modified rtcp.reducedSize should reject with InvalidModificationError: FAIL (Chrome: PASS, Safari: FAIL)
/webrtc/RTCRtpParameters-encodings.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-asan-opt, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)
setParameters() with encoding.scaleResolutionDownBy field set to less than 1.0 should reject with RangeError: FAIL (Chrome: PASS, Safari: FAIL)
setParameters() with modified encoding.scaleResolutionDownBy should succeed without RTCRtpTransceiverInit: FAIL (Chrome: PASS, Safari: FAIL)
setParameters() with modified encoding.active should succeed without RTCRtpTransceiverInit: FAIL (Chrome: PASS, Safari: FAIL)
setParameters() with modified encoding.scaleResolutionDownBy should succeed with RTCRtpTransceiverInit: FAIL (Chrome: PASS, Safari: FAIL)
setParameters() with modified encoding.maxBitrate should succeed with RTCRtpTransceiverInit: FAIL (Chrome: PASS, Safari: FAIL)
addTransceiver() with undefined sendEncodings should have default encoding parameter with active set to true: FAIL (Chrome: PASS, Safari: FAIL)
setParameters() with modified encoding.maxBitrate should succeed without RTCRtpTransceiverInit: FAIL (Chrome: PASS, Safari: FAIL)
setParameters() with modified encoding.priority should succeed with RTCRtpTransceiverInit: FAIL (Chrome: PASS, Safari: FAIL)
sender.setParameters() with mismatch number of encodings should reject with InvalidModificationError: FAIL (Chrome: PASS, Safari: FAIL)
addTransceiver() with empty list sendEncodings should have default encoding parameter with active set to true: FAIL (Chrome: PASS, Safari: FAIL)
sender.getParameters() should return sendEncodings set by addTransceiver(): FAIL (Chrome: PASS, Safari: FAIL)
sender.setParameters() with encodings unset should reject with TypeError: FAIL (Chrome: PASS, Safari: FAIL)
setParameters() with modified encoding.priority should succeed without RTCRtpTransceiverInit: FAIL (Chrome: PASS, Safari: FAIL)
setParameters() with modified encoding.active should succeed with RTCRtpTransceiverInit: FAIL (Chrome: PASS, Safari: FAIL)
setParameters() with encoding.scaleResolutionDownBy field set to greater than 1.0 should succeed: FAIL (Chrome: PASS, Safari: FAIL)
setParameters() with modified encoding.networkPriority should succeed without RTCRtpTransceiverInit: FAIL (Chrome: PASS, Safari: FAIL)
setParameters() with modified encoding.networkPriority should succeed with RTCRtpTransceiverInit: FAIL (Chrome: PASS, Safari: FAIL)
setParameters() with modified encoding.rid field should reject with InvalidModificationError: FAIL (Chrome: PASS, Safari: FAIL)
/webrtc/RTCRtpParameters-degradationPreference.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-asan-opt, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)
setParameters with degradationPreference unset should succeed: FAIL (Chrome: FAIL, Safari: FAIL)
setParameters with degradationPreference set should succeed: FAIL (Chrome: FAIL, Safari: FAIL)
/webrtc/RTCRtpReceiver-getParameters.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-asan-opt, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)
getParameters() with simulcast video receiver: FAIL (Chrome: FAIL, Safari: FAIL)
getParameters() with video receiver: FAIL (Chrome: PASS, Safari: FAIL)
getParameters() with audio receiver: FAIL (Chrome: PASS, Safari: FAIL)
/webrtc-svc/RTCRtpParameters-scalability.html
Setting scalabilityMode to a legal value should be accepted: FAIL (Chrome: PASS, Safari: FAIL)
Sender capabilities should include at least some scalability modes: FAIL (Chrome: PASS, Safari: FAIL)

Tests Disabled in Gecko Infrastructure

/webrtc/RTCRtpParameters-headerExtensions.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-asan-opt, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)
/webrtc/RTCRtpParameters-codecs.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-asan-opt, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)
/webrtc/RTCRtpParameters-transactionId.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-asan-opt, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)
/webrtc/RTCRtpParameters-rtcp.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-asan-opt, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)
/webrtc/RTCRtpParameters-encodings.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-asan-opt, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)
/webrtc/RTCRtpParameters-degradationPreference.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-asan-opt, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)
/webrtc/RTCRtpReceiver-getParameters.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-asan-opt, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2bafdd1a1f50
[wpt PR 21264] - webrtc: Implement and ship RTCRtpEncodingParameters.maxFramerate, a=testonly
https://hg.mozilla.org/integration/autoland/rev/87356b5be559
[wpt PR 21264] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/2bafdd1a1f50
https://hg.mozilla.org/mozilla-central/rev/87356b5be559

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox74: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
You need to log in before you can comment on or make changes to this bug.