Closed Bug 1610317 Opened 4 years ago Closed 11 months ago

Use "SpecialPowers.spawn" instead of "ContentTask.spawn" in browser chrome tests for CDP

Categories

(Remote Protocol :: CDP, task, P3)

task

Tracking

(firefox113 fixed)

RESOLVED FIXED
113 Branch
Tracking Status
firefox113 --- fixed

People

(Reporter: whimboo, Assigned: ofrazy, Mentored)

References

Details

(Whiteboard: [lang=js])

Attachments

(1 file)

For Fission compatibility ContentTask.spawn() shouldn't be used. Right now it's necessary because we have to track the webprogress listener across an ongoing page load.

We have to find an alternative for determining the docShell's load flags.

Fission Milestone: --- → M6c

Removing the use of ContentTask.spawn here shouldn't block Fission, so moving to Future.

Fission Milestone: M6c → Future
Component: CDP: Network → CDP

Here a link that references tests that still make use of ContentTask.spawn():
https://searchfox.org/mozilla-central/search?q=ContentTask.spawn&path=remote%2F&case=false&regexp=false

Mentor: hskupin
Whiteboard: [lang=js]
Fission Milestone: Future → ---
Severity: normal → S3
Summary: Use "SpecialPowers.spawn" instead of "ContentTask.spawn" in remote/test/browser/network/browser_setCacheDisabled.js → Use "SpecialPowers.spawn" instead of "ContentTask.spawn" in browser chrome tests for CDP

Can I proceed to work on this bug?

Yes, please do so. As long as there is no assignee for the bug you can get started. Once a patch is uploaded we consider a bug as taken. Thanks!

Assignee: nobody → ofrazy
Status: NEW → ASSIGNED
Attachment #9322673 - Attachment description: Bug 1610317 - use SpecialPowers.spawn instead of ContentTask.spawn in browser chrome tests for CDP → Bug 1610317 - [cdp] Use SpecialPowers.spawn instead of ContentTask.spawn in browser chrome tests.
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ec774797366e
[cdp] Use SpecialPowers.spawn instead of ContentTask.spawn in browser chrome tests. r=webdriver-reviewers,whimboo
Status: ASSIGNED → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → 113 Branch
You need to log in before you can comment on or make changes to this bug.