1610377 - Intermittent remote/test/browser/page/browser_getNavigationHistory.js | Got expected current index - Got 2, expected 0

Status: RESOLVED FIXED

(Remote Protocol :: Agent, defect, P1)

Description

[Treeherder Bug Filer]

Filed by: rmaries [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=285674373&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/ENUxK_TpTB-1C5ahm-ZXYg/runs/0/artifacts/public/logs/live_backing.log

---

[task 2020-01-20T20:31:16.910Z] 20:31:16 INFO - TEST-START | remote/test/browser/page/browser_getNavigationHistory.js
[task 2020-01-20T20:31:18.841Z] 20:31:18 INFO - TEST-INFO | started process screentopng
[task 2020-01-20T20:31:19.170Z] 20:31:19 INFO - TEST-INFO | screentopng: exit 0
[task 2020-01-20T20:31:19.170Z] 20:31:19 INFO - Buffered messages logged at 20:31:16
[task 2020-01-20T20:31:19.170Z] 20:31:19 INFO - Entering test bound singleEntry
[task 2020-01-20T20:31:19.170Z] 20:31:19 INFO - CDP server started
[task 2020-01-20T20:31:19.170Z] 20:31:19 INFO - Buffered messages logged at 20:31:17
[task 2020-01-20T20:31:19.170Z] 20:31:19 INFO - CDP client instantiated
[task 2020-01-20T20:31:19.170Z] 20:31:19 INFO - TEST-PASS | remote/test/browser/page/browser_getNavigationHistory.js | Got expected current index -
[task 2020-01-20T20:31:19.170Z] 20:31:19 INFO - TEST-PASS | remote/test/browser/page/browser_getNavigationHistory.js | Found expected count of history entries -
[task 2020-01-20T20:31:19.170Z] 20:31:19 INFO - TEST-PASS | remote/test/browser/page/browser_getNavigationHistory.js | History entry has an id set -
[task 2020-01-20T20:31:19.170Z] 20:31:19 INFO - TEST-PASS | remote/test/browser/page/browser_getNavigationHistory.js | History entry has the correct URL set -
[task 2020-01-20T20:31:19.170Z] 20:31:19 INFO - TEST-PASS | remote/test/browser/page/browser_getNavigationHistory.js | History entry has the correct user typed URL set -
[task 2020-01-20T20:31:19.170Z] 20:31:19 INFO - TEST-PASS | remote/test/browser/page/browser_getNavigationHistory.js | History entry has the correct title set -
[task 2020-01-20T20:31:19.170Z] 20:31:19 INFO - CDP client closed
[task 2020-01-20T20:31:19.171Z] 20:31:19 INFO - CDP server stopped
[task 2020-01-20T20:31:19.171Z] 20:31:19 INFO - Leaving test bound singleEntry
[task 2020-01-20T20:31:19.171Z] 20:31:19 INFO - Entering test bound multipleEntriesWithLastIndex
[task 2020-01-20T20:31:19.171Z] 20:31:19 INFO - CDP server started
[task 2020-01-20T20:31:19.171Z] 20:31:19 INFO - CDP client instantiated
[task 2020-01-20T20:31:19.171Z] 20:31:19 INFO - Buffered messages logged at 20:31:18
[task 2020-01-20T20:31:19.171Z] 20:31:19 INFO - TEST-PASS | remote/test/browser/page/browser_getNavigationHistory.js | Got expected current index -
[task 2020-01-20T20:31:19.171Z] 20:31:19 INFO - TEST-PASS | remote/test/browser/page/browser_getNavigationHistory.js | Found expected count of history entries -
[task 2020-01-20T20:31:19.171Z] 20:31:19 INFO - TEST-PASS | remote/test/browser/page/browser_getNavigationHistory.js | History entry has an id set -
[task 2020-01-20T20:31:19.171Z] 20:31:19 INFO - TEST-PASS | remote/test/browser/page/browser_getNavigationHistory.js | History entry has the correct URL set -
[task 2020-01-20T20:31:19.171Z] 20:31:19 INFO - TEST-PASS | remote/test/browser/page/browser_getNavigationHistory.js | History entry has the correct user typed URL set -
[task 2020-01-20T20:31:19.171Z] 20:31:19 INFO - TEST-PASS | remote/test/browser/page/browser_getNavigationHistory.js | History entry has the correct title set -
[task 2020-01-20T20:31:19.171Z] 20:31:19 INFO - TEST-PASS | remote/test/browser/page/browser_getNavigationHistory.js | History entry has an id set -
[task 2020-01-20T20:31:19.171Z] 20:31:19 INFO - TEST-PASS | remote/test/browser/page/browser_getNavigationHistory.js | History entry has the correct URL set -
[task 2020-01-20T20:31:19.171Z] 20:31:19 INFO - TEST-PASS | remote/test/browser/page/browser_getNavigationHistory.js | History entry has the correct user typed URL set -
[task 2020-01-20T20:31:19.171Z] 20:31:19 INFO - TEST-PASS | remote/test/browser/page/browser_getNavigationHistory.js | History entry has the correct title set -
[task 2020-01-20T20:31:19.171Z] 20:31:19 INFO - TEST-PASS | remote/test/browser/page/browser_getNavigationHistory.js | History entry has an id set -
[task 2020-01-20T20:31:19.171Z] 20:31:19 INFO - TEST-PASS | remote/test/browser/page/browser_getNavigationHistory.js | History entry has the correct URL set -
[task 2020-01-20T20:31:19.171Z] 20:31:19 INFO - TEST-PASS | remote/test/browser/page/browser_getNavigationHistory.js | History entry has the correct user typed URL set -
[task 2020-01-20T20:31:19.171Z] 20:31:19 INFO - TEST-PASS | remote/test/browser/page/browser_getNavigationHistory.js | History entry has the correct title set -
[task 2020-01-20T20:31:19.171Z] 20:31:19 INFO - CDP client closed
[task 2020-01-20T20:31:19.171Z] 20:31:19 INFO - CDP server stopped
[task 2020-01-20T20:31:19.171Z] 20:31:19 INFO - Leaving test bound multipleEntriesWithLastIndex
[task 2020-01-20T20:31:19.171Z] 20:31:19 INFO - Entering test bound multipleEntriesWithFirstIndex
[task 2020-01-20T20:31:19.174Z] 20:31:19 INFO - CDP server started
[task 2020-01-20T20:31:19.174Z] 20:31:19 INFO - CDP client instantiated
[task 2020-01-20T20:31:19.174Z] 20:31:19 INFO - Buffered messages finished
[task 2020-01-20T20:31:19.175Z] 20:31:19 INFO - TEST-UNEXPECTED-FAIL | remote/test/browser/page/browser_getNavigationHistory.js | Got expected current index - Got 2, expected 0
[task 2020-01-20T20:31:19.175Z] 20:31:19 INFO - Stack trace:
[task 2020-01-20T20:31:19.176Z] 20:31:19 INFO - chrome://mochikit/content/browser-test.js:test_is:1320
[task 2020-01-20T20:31:19.176Z] 20:31:19 INFO - chrome://mochitests/content/browser/remote/test/browser/page/head.js:assertHistoryEntries:16
[task 2020-01-20T20:31:19.176Z] 20:31:19 INFO - chrome://mochitests/content/browser/remote/test/browser/page/browser_getNavigationHistory.js:multipleEntriesWithFirstIndex:41
[task 2020-01-20T20:31:19.176Z] 20:31:19 INFO - chrome://mochitests/content/browser/remote/test/browser/head.js:fn:67
[task 2020-01-20T20:31:19.176Z] 20:31:19 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1062
[task 2020-01-20T20:31:19.177Z] 20:31:19 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1097
[task 2020-01-20T20:31:19.177Z] 20:31:19 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:925
[task 2020-01-20T20:31:19.177Z] 20:31:19 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:808
[task 2020-01-20T20:31:19.178Z] 20:31:19 INFO - TEST-PASS | remote/test/browser/page/browser_getNavigationHistory.js | Found expected count of history entries -
[task 2020-01-20T20:31:19.178Z] 20:31:19 INFO - TEST-PASS | remote/test/browser/page/browser_getNavigationHistory.js | History entry has an id set -
[task 2020-01-20T20:31:19.179Z] 20:31:19 INFO - TEST-PASS | remote/test/browser/page/browser_getNavigationHistory.js | History entry has the correct URL set -
[task 2020-01-20T20:31:19.179Z] 20:31:19 INFO - TEST-PASS | remote/test/browser/page/browser_getNavigationHistory.js | History entry has the correct user typed URL set -
[task 2020-01-20T20:31:19.182Z] 20:31:19 INFO - TEST-PASS | remote/test/browser/page/browser_getNavigationHistory.js | History entry has the correct title set -
[task 2020-01-20T20:31:19.182Z] 20:31:19 INFO - TEST-PASS | remote/test/browser/page/browser_getNavigationHistory.js | History entry has an id set -
[task 2020-01-20T20:31:19.184Z] 20:31:19 INFO - TEST-PASS | remote/test/browser/page/browser_getNavigationHistory.js | History entry has the correct URL set -
[task 2020-01-20T20:31:19.184Z] 20:31:19 INFO - TEST-PASS | remote/test/browser/page/browser_getNavigationHistory.js | History entry has the correct user typed URL set -
[task 2020-01-20T20:31:19.184Z] 20:31:19 INFO - TEST-PASS | remote/test/browser/page/browser_getNavigationHistory.js | History entry has the correct title set -
[task 2020-01-20T20:31:19.185Z] 20:31:19 INFO - TEST-PASS | remote/test/browser/page/browser_getNavigationHistory.js | History entry has an id set -
[task 2020-01-20T20:31:19.185Z] 20:31:19 INFO - TEST-PASS | remote/test/browser/page/browser_getNavigationHistory.js | History entry has the correct URL set -
[task 2020-01-20T20:31:19.185Z] 20:31:19 INFO - TEST-PASS | remote/test/browser/page/browser_getNavigationHistory.js | History entry has the correct user typed URL set -
[task 2020-01-20T20:31:19.186Z] 20:31:19 INFO - TEST-PASS | remote/test/browser/page/browser_getNavigationHistory.js | History entry has the correct title set -
[task 2020-01-20T20:31:19.187Z] 20:31:19 INFO - CDP client closed
[task 2020-01-20T20:31:19.187Z] 20:31:19 INFO - CDP server stopped
[task 2020-01-20T20:31:19.187Z] 20:31:19 INFO - Leaving test bound multipleEntriesWithFirstIndex
[task 2020-01-20T20:31:19.188Z] 20:31:19 INFO - Entering test bound locationRedirect
[task 2020-01-20T20:31:19.188Z] 20:31:19 INFO - CDP server started
[task 2020-01-20T20:31:19.465Z] 20:31:19 INFO - CDP client instantiated
[task 2020-01-20T20:31:19.587Z] 20:31:19 INFO - Console message: [JavaScript Error: "The character encoding of the HTML document was not declared. The document will render with garbled text in some browser configurations if the document contains characters from outside the US-ASCII range. The character encoding of the page must be declared in the document or in the transfer protocol." {file: "http://example.com/browser/remote/test/browser/page/doc_empty.html" line: 0}]
[task 2020-01-20T20:31:19.627Z] 20:31:19 INFO - TEST-PASS | remote/test/browser/page/browser_getNavigationHistory.js | Got expected current index -
[task 2020-01-20T20:31:19.629Z] 20:31:19 INFO - TEST-PASS | remote/test/browser/page/browser_getNavigationHistory.js | Found expected count of history entries -
[task 2020-01-20T20:31:19.632Z] 20:31:19 INFO - TEST-PASS | remote/test/browser/page/browser_getNavigationHistory.js | History entry has an id set -
[task 2020-01-20T20:31:19.632Z] 20:31:19 INFO - TEST-PASS | remote/test/browser/page/browser_getNavigationHistory.js | History entry has the correct URL set -
[task 2020-01-20T20:31:19.632Z] 20:31:19 INFO - TEST-PASS | remote/test/browser/page/browser_getNavigationHistory.js | History entry has the correct user typed URL set -
[task 2020-01-20T20:31:19.634Z] 20:31:19 INFO - TEST-PASS | remote/test/browser/page/browser_getNavigationHistory.js | History entry has the correct title set -
[task 2020-01-20T20:31:19.662Z] 20:31:19 INFO - CDP client closed
[task 2020-01-20T20:31:19.679Z] 20:31:19 INFO - CDP server stopped
[task 2020-01-20T20:31:19.679Z] 20:31:19 INFO - Leaving test bound locationRedirect
[task 2020-01-20T20:31:19.691Z] 20:31:19 INFO - GECKO(3495) | MEMORY STAT | vsize 3103MB | residentFast 414MB | heapAllocated 164MB
[task 2020-01-20T20:31:19.691Z] 20:31:19 INFO - TEST-OK | remote/test/browser/page/browser_getNavigationHistory.js | took 2774ms
[task 2020-01-20T20:31:19.700Z] 20:31:19 INFO - checking window state

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Navigation to the first history index hasn't been finished as it looks like. Maybe on some systems gBrowser.gotoIndex() is asynchronous? None of the other browser chrome tests actually use a promise here for waiting.

Fixing this failure should also fix the other failures (see dependency list).

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

This also looks to be Linux only, so I will have to take a look at it tomorrow.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

This actually fails a lot over the last two days. So I'm going to have a look at.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1610377 - [remote] Always use the docshell for navigating the history.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I just saw the comment from Nika about possibly deprecating the docShell.gotoIndex() API. So the change as proposed here wouldn't be ideal.

Nika, which API should be used instead? Is it gBrowser.gotoIndex(), or would that also be affected? Also for which kind of event I would have to wait for in the parent process to ensure that the command has been finished? Thanks.

Comment 6

[Nika Layzell [:nika] (ni? for response)]

(In reply to Henrik Skupin (:whimboo) [⌚️UTC+1] from comment #5)

I just saw the comment from Nika about possibly deprecating the docShell.gotoIndex() API. So the change as proposed here wouldn't be ideal.

Nika, which API should be used instead? Is it gBrowser.gotoIndex(), or would that also be affected?

I would not recommend making this change as it is written, as it's not compatible with the changes we're planning to do with Session History for Fission (see bug 1467221 and it's blockers). The gBrowser.gotoIndex API is unlikely to be affected by these changes, as it already exists only in the parent process, and can be rewired internally to call our new in-parent APIs as we move session history state into the parent.

The operation of navigating a document, either through history or otherwise, is fundamentally asynchronous, as we may have to perform network requests, and likely need to talk to the content process, so you'll definitely need to add code to wait for the history navigation to complete.

Also for which kind of event I would have to wait for in the parent process to ensure that the command has been finished? Thanks.

I don't know off the top of my head if there is a specific event to listen to. History navigations can vary a lot in how they are actually executed, as the document could be (off the top of my head): an anchor navigation, a pushstate navigation, a bfcache restore, a network load, a subframe (pushstate,anchor,load), or a combination of any of the above. Any of these requests could also end up being canceled, and never complete.

For specific test cases, it's possible to know the correct type of event to wait for, and wait for it, but in general it's hard to know exactly what type of navigation will be performed. I'll ni? :smaug in case he knows of a good way, though.

AFAICT this is for use in the remote debugger API, which I'm not familiar with the definition for. Is it necessary for this API to wait for the load to complete? I would expect this and other navigation APIs to start the navigation, but not wait for the document to be fully navigated, like the web-exposed history.go(...) API.

FYI, the session history information which you're reading from the content process is already somewhat available in the parent using Session Restore, which is how things such as a long press on the back button are handled. In the future, we are planning to not have this information available in child processes at all. It would be better to avoid reading this information from the content process if possible.

Comment 7

[Andreea Pavel [:apavel]]

There are 48 total failures in the last 7 days on

• linux1804-64 debug and opt
• linux1804-64-asan opt
• macosx1014-64 debug (2 failures)
• windows7-32 debug (5 failures)
• windows7-32-shippable opt (8 failures)

Recent failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=286517358&repo=autoland&lineNumber=2391

[task 2020-01-26T06:04:12.277Z] 06:04:12 INFO - TEST-START | remote/test/browser/page/browser_getNavigationHistory.js
[task 2020-01-26T06:04:13.957Z] 06:04:13 INFO - TEST-INFO | started process screentopng
[task 2020-01-26T06:04:14.270Z] 06:04:14 INFO - TEST-INFO | screentopng: exit 0
[task 2020-01-26T06:04:14.270Z] 06:04:14 INFO - Buffered messages logged at 06:04:12
[task 2020-01-26T06:04:14.271Z] 06:04:14 INFO - Entering test bound singleEntry
[task 2020-01-26T06:04:14.271Z] 06:04:14 INFO - CDP server started
[task 2020-01-26T06:04:14.272Z] 06:04:14 INFO - CDP client instantiated
[task 2020-01-26T06:04:14.273Z] 06:04:14 INFO - TEST-PASS | remote/test/browser/page/browser_getNavigationHistory.js | Got expected current index -
[task 2020-01-26T06:04:14.273Z] 06:04:14 INFO - TEST-PASS | remote/test/browser/page/browser_getNavigationHistory.js | Found expected count of history entries -
[task 2020-01-26T06:04:14.274Z] 06:04:14 INFO - TEST-PASS | remote/test/browser/page/browser_getNavigationHistory.js | History entry has an id set -
[task 2020-01-26T06:04:14.275Z] 06:04:14 INFO - TEST-PASS | remote/test/browser/page/browser_getNavigationHistory.js | History entry has the correct URL set -
[task 2020-01-26T06:04:14.275Z] 06:04:14 INFO - TEST-PASS | remote/test/browser/page/browser_getNavigationHistory.js | History entry has the correct user typed URL set -
[task 2020-01-26T06:04:14.276Z] 06:04:14 INFO - TEST-PASS | remote/test/browser/page/browser_getNavigationHistory.js | History entry has the correct title set -
[task 2020-01-26T06:04:14.276Z] 06:04:14 INFO - CDP client closed
[task 2020-01-26T06:04:14.278Z] 06:04:14 INFO - CDP server stopped
[task 2020-01-26T06:04:14.278Z] 06:04:14 INFO - Leaving test bound singleEntry
[task 2020-01-26T06:04:14.279Z] 06:04:14 INFO - Entering test bound multipleEntriesWithLastIndex
[task 2020-01-26T06:04:14.279Z] 06:04:14 INFO - CDP server started
[task 2020-01-26T06:04:14.280Z] 06:04:14 INFO - Buffered messages logged at 06:04:13
[task 2020-01-26T06:04:14.280Z] 06:04:14 INFO - CDP client instantiated
[task 2020-01-26T06:04:14.281Z] 06:04:14 INFO - TEST-PASS | remote/test/browser/page/browser_getNavigationHistory.js | Got expected current index -
[task 2020-01-26T06:04:14.282Z] 06:04:14 INFO - TEST-PASS | remote/test/browser/page/browser_getNavigationHistory.js | Found expected count of history entries -
[task 2020-01-26T06:04:14.284Z] 06:04:14 INFO - TEST-PASS | remote/test/browser/page/browser_getNavigationHistory.js | History entry has an id set -
[task 2020-01-26T06:04:14.285Z] 06:04:14 INFO - TEST-PASS | remote/test/browser/page/browser_getNavigationHistory.js | History entry has the correct URL set -
[task 2020-01-26T06:04:14.285Z] 06:04:14 INFO - TEST-PASS | remote/test/browser/page/browser_getNavigationHistory.js | History entry has the correct user typed URL set -
[task 2020-01-26T06:04:14.286Z] 06:04:14 INFO - TEST-PASS | remote/test/browser/page/browser_getNavigationHistory.js | History entry has the correct title set -
[task 2020-01-26T06:04:14.286Z] 06:04:14 INFO - TEST-PASS | remote/test/browser/page/browser_getNavigationHistory.js | History entry has an id set -
[task 2020-01-26T06:04:14.287Z] 06:04:14 INFO - TEST-PASS | remote/test/browser/page/browser_getNavigationHistory.js | History entry has the correct URL set -
[task 2020-01-26T06:04:14.287Z] 06:04:14 INFO - TEST-PASS | remote/test/browser/page/browser_getNavigationHistory.js | History entry has the correct user typed URL set -
[task 2020-01-26T06:04:14.288Z] 06:04:14 INFO - TEST-PASS | remote/test/browser/page/browser_getNavigationHistory.js | History entry has the correct title set -
[task 2020-01-26T06:04:14.288Z] 06:04:14 INFO - TEST-PASS | remote/test/browser/page/browser_getNavigationHistory.js | History entry has an id set -
[task 2020-01-26T06:04:14.289Z] 06:04:14 INFO - TEST-PASS | remote/test/browser/page/browser_getNavigationHistory.js | History entry has the correct URL set -
[task 2020-01-26T06:04:14.289Z] 06:04:14 INFO - TEST-PASS | remote/test/browser/page/browser_getNavigationHistory.js | History entry has the correct user typed URL set -
[task 2020-01-26T06:04:14.290Z] 06:04:14 INFO - TEST-PASS | remote/test/browser/page/browser_getNavigationHistory.js | History entry has the correct title set -
[task 2020-01-26T06:04:14.291Z] 06:04:14 INFO - CDP client closed
[task 2020-01-26T06:04:14.292Z] 06:04:14 INFO - CDP server stopped
[task 2020-01-26T06:04:14.292Z] 06:04:14 INFO - Leaving test bound multipleEntriesWithLastIndex
[task 2020-01-26T06:04:14.293Z] 06:04:14 INFO - Entering test bound multipleEntriesWithFirstIndex
[task 2020-01-26T06:04:14.293Z] 06:04:14 INFO - CDP server started
[task 2020-01-26T06:04:14.294Z] 06:04:14 INFO - CDP client instantiated
[task 2020-01-26T06:04:14.294Z] 06:04:14 INFO - Buffered messages finished
[task 2020-01-26T06:04:14.296Z] 06:04:14 INFO - TEST-UNEXPECTED-FAIL | remote/test/browser/page/browser_getNavigationHistory.js | Got expected current index - Got 2, expected 0
[task 2020-01-26T06:04:14.296Z] 06:04:14 INFO - Stack trace:
[task 2020-01-26T06:04:14.297Z] 06:04:14 INFO - chrome://mochikit/content/browser-test.js:test_is:1320
[task 2020-01-26T06:04:14.297Z] 06:04:14 INFO - chrome://mochitests/content/browser/remote/test/browser/page/head.js:assertHistoryEntries:16
[task 2020-01-26T06:04:14.298Z] 06:04:14 INFO - chrome://mochitests/content/browser/remote/test/browser/page/browser_getNavigationHistory.js:multipleEntriesWithFirstIndex:41
[task 2020-01-26T06:04:14.298Z] 06:04:14 INFO - chrome://mochitests/content/browser/remote/test/browser/head.js:fn:67
[task 2020-01-26T06:04:14.299Z] 06:04:14 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1062
[task 2020-01-26T06:04:14.299Z] 06:04:14 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1097
[task 2020-01-26T06:04:14.299Z] 06:04:14 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:925
[task 2020-01-26T06:04:14.300Z] 06:04:14 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:808
[task 2020-01-26T06:04:14.300Z] 06:04:14 INFO - TEST-PASS | remote/test/browser/page/browser_getNavigationHistory.js | Found expected count of history entries -
[task 2020-01-26T06:04:14.300Z] 06:04:14 INFO - TEST-PASS | remote/test/browser/page/browser_getNavigationHistory.js | History entry has an id set -
[task 2020-01-26T06:04:14.301Z] 06:04:14 INFO - TEST-PASS | remote/test/browser/page/browser_getNavigationHistory.js | History entry has the correct URL set -
[task 2020-01-26T06:04:14.301Z] 06:04:14 INFO - TEST-PASS | remote/test/browser/page/browser_getNavigationHistory.js | History entry has the correct user typed URL set -
[task 2020-01-26T06:04:14.302Z] 06:04:14 INFO - TEST-PASS | remote/test/browser/page/browser_getNavigationHistory.js | History entry has the correct title set -
[task 2020-01-26T06:04:14.302Z] 06:04:14 INFO - TEST-PASS | remote/test/browser/page/browser_getNavigationHistory.js | History entry has an id set -
[task 2020-01-26T06:04:14.303Z] 06:04:14 INFO - TEST-PASS | remote/test/browser/page/browser_getNavigationHistory.js | History entry has the correct URL set -
[task 2020-01-26T06:04:14.304Z] 06:04:14 INFO - TEST-PASS | remote/test/browser/page/browser_getNavigationHistory.js | History entry has the correct user typed URL set -
[task 2020-01-26T06:04:14.304Z] 06:04:14 INFO - TEST-PASS | remote/test/browser/page/browser_getNavigationHistory.js | History entry has the correct title set -
[task 2020-01-26T06:04:14.305Z] 06:04:14 INFO - TEST-PASS | remote/test/browser/page/browser_getNavigationHistory.js | History entry has an id set -
[task 2020-01-26T06:04:14.306Z] 06:04:14 INFO - TEST-PASS | remote/test/browser/page/browser_getNavigationHistory.js | History entry has the correct URL set -
[task 2020-01-26T06:04:14.306Z] 06:04:14 INFO - TEST-PASS | remote/test/browser/page/browser_getNavigationHistory.js | History entry has the correct user typed URL set -
[task 2020-01-26T06:04:14.307Z] 06:04:14 INFO - TEST-PASS | remote/test/browser/page/browser_getNavigationHistory.js | History entry has the correct title set -
[task 2020-01-26T06:04:14.307Z] 06:04:14 INFO - CDP client closed
[task 2020-01-26T06:04:14.307Z] 06:04:14 INFO - CDP server stopped
[task 2020-01-26T06:04:14.307Z] 06:04:14 INFO - Leaving test bound multipleEntriesWithFirstIndex
[task 2020-01-26T06:04:14.307Z] 06:04:14 INFO - Entering test bound locationRedirect
[task 2020-01-26T06:04:14.308Z] 06:04:14 INFO - CDP server started
[task 2020-01-26T06:04:14.456Z] 06:04:14 INFO - CDP client instantiated
[task 2020-01-26T06:04:14.553Z] 06:04:14 INFO - Console message: [JavaScript Error: "The character encoding of the HTML document was not declared. The document will render with garbled text in some browser configurations if the document contains characters from outside the US-ASCII range. The character encoding of the page must be declared in the document or in the transfer protocol." {file: "http://example.com/browser/remote/test/browser/page/doc_empty.html" line: 0}]
[task 2020-01-26T06:04:14.576Z] 06:04:14 INFO - TEST-PASS | remote/test/browser/page/browser_getNavigationHistory.js | Got expected current index -
[task 2020-01-26T06:04:14.577Z] 06:04:14 INFO - TEST-PASS | remote/test/browser/page/browser_getNavigationHistory.js | Found expected count of history entries -
[task 2020-01-26T06:04:14.577Z] 06:04:14 INFO - TEST-PASS | remote/test/browser/page/browser_getNavigationHistory.js | History entry has an id set -
[task 2020-01-26T06:04:14.578Z] 06:04:14 INFO - TEST-PASS | remote/test/browser/page/browser_getNavigationHistory.js | History entry has the correct URL set -
[task 2020-01-26T06:04:14.578Z] 06:04:14 INFO - TEST-PASS | remote/test/browser/page/browser_getNavigationHistory.js | History entry has the correct user typed URL set -
[task 2020-01-26T06:04:14.582Z] 06:04:14 INFO - TEST-PASS | remote/test/browser/page/browser_getNavigationHistory.js | History entry has the correct title set -
[task 2020-01-26T06:04:14.617Z] 06:04:14 INFO - CDP client closed
[task 2020-01-26T06:04:14.625Z] 06:04:14 INFO - CDP server stopped
[task 2020-01-26T06:04:14.626Z] 06:04:14 INFO - Leaving test bound locationRedirect
[task 2020-01-26T06:04:14.654Z] 06:04:14 INFO - GECKO(3538) | MEMORY STAT | vsize 3183MB | residentFast 405MB | heapAllocated 161MB
[task 2020-01-26T06:04:14.654Z] 06:04:14 INFO - TEST-OK | remote/test/browser/page/browser_getNavigationHistory.js | took 2380ms
[task 2020-01-26T06:04:14.694Z] 06:04:14 INFO - checking window state

Comment 8

[Intermittent Failures Robot]

58 failures in 4004 pushes (0.014 failures/push) were associated with this bug in the last 7 days.

This is the #17 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• autoland: 38
• mozilla-central: 15
• try: 5

Platform breakdown:

• linux1804-64: 23
• windows10-64-shippable: 1
• linux1804-64-shippable: 9
• windows7-32: 5
• macosx1014-64: 2
• windows7-32-shippable: 8
• linux1804-64-asan: 9
• windows10-64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1610377&startday=2020-01-20&endday=2020-01-26&tree=all

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to :Nika Layzell (ni? for response) from comment #6)

I would not recommend making this change as it is written, as it's not compatible with the changes we're planning to do with Session History for Fission (see bug 1467221 and it's blockers). The gBrowser.gotoIndex API is unlikely to be affected by these changes, as it already exists only in the parent process, and can be rewired internally to call our new in-parent APIs as we move session history state into the parent.

That is good to know. I will keep the code as is then.

AFAICT this is for use in the remote debugger API, which I'm not familiar with the definition for. Is it necessary for this API to wait for the load to complete? I would expect this and other navigation APIs to start the navigation, but not wait for the document to be fully navigated, like the web-

In this specific case it would be important to wait for the current index of history to have been updated. That is what we currently fail on. If there is no event I might have to poll for it.

FYI, the session history information which you're reading from the content process is already somewhat available in the parent using Session Restore, which is how things such as a long press on the back button are handled. In the future, we are planning to not have this information available in child processes at all. It would be better to avoid reading this information from the content process if possible.

Thanks. I would have to search how to get this information from. I would propose to make it a follow-up bug because it's not needed to fix this test failure.

Comment 10

[Olli Pettay [:smaug][[e-mail]]]

I hope the links I gave on IRC were useful for this bug. If not, needinfo me again :)

Comment 11

[Intermittent Failures Robot]

35 failures in 2190 pushes (0.016 failures/push) were associated with this bug in the last 7 days.

This is the #12 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• autoland: 20
• mozilla-central: 13
• try: 2

Platform breakdown:

• linux1804-64-asan: 12
• linux1804-64: 10
• macosx1014-64: 1
• linux1804-64-shippable: 7
• windows7-32-shippable: 1
• linux1804-64-ccov: 1
• macosx1014-64-shippable: 3

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1610377&startday=2020-01-27&endday=2020-02-02&tree=all

Comment 12

[Cosmin Sabou [:CosminS]]

Update: this has 47 total failures in the last 7 days and 129 total failures in the last 30, most of them on linux1804-64 opt: https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?startday=2020-01-10&endday=2020-02-09&tree=trunk&bug=1610377
Recent failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=288084411&repo=autoland
Henrik, any updates on this? Thank you.

Comment 13

[Intermittent Failures Robot]

46 failures in 3364 pushes (0.014 failures/push) were associated with this bug in the last 7 days.

This is the #7 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• mozilla-central: 13
• autoland: 31
• try: 2

Platform breakdown:

• linux1804-64: 16
• macosx1014-64-shippable: 1
• linux1804-64-asan: 16
• linux1804-64-shippable: 11
• windows10-64-shippable: 1
• windows10-64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1610377&startday=2020-02-03&endday=2020-02-09&tree=all

Comment 14

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to Olli Pettay [:smaug] from comment #10)

I hope the links I gave on IRC were useful for this bug. If not, needinfo me again :)

Olli, due to a Catalina upgrade on my MBP I lost all the patches which were saved under .hg locally. Sadly this folder wasn't backuped. :/

Maybe you can remember what you proposed I should do here? Basically I now know that I have to do all the navigation in the parent process, and as such should also listen there for the page load events or by using a web progress listener. Whereby I might not have to wait for the page to be loaded, but only for the requested index in the history to be set.

Comment 15

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Short update. I was able to move all the code from the framescript into the parent process, and access the session history via SessionStore.getSessionHistory(). As such this code helps in making the remote agent more fission compatible.

I still have to check what to wait for in the parent process.

Comment 16

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Checking the code of navigateToHistoryEntry in CDP, and the _go() method in Puppeteer, it is clear that this method doesn't wait for the navigation to be completed.

So I'm only updating the browser chrome tests, to wait for the right index to be set when using gBrowser.gotoIndex().

Comment 17

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1610377 - [remote] Move session history navigation code into the parent process.

Comment 18

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1610377 - [remote] Wait for history index selected when using gBrowser.gotoIndex().

Depends on D62588

Comment 19

[Henrik Skupin [:whimboo][⌚️UTC+1]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=dcc0a3c6f098173ed7e45f09460d6e9ded3f4f99

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6f15878925ca
[remote] Move session history navigation code into the parent process. r=remote-protocol-reviewers,maja_zf
https://hg.mozilla.org/integration/autoland/rev/d45350ccf8aa
[remote] Wait for history index selected when using gBrowser.gotoIndex(). r=remote-protocol-reviewers,maja_zf

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bf5ac2c3466b
Fix lint error in remote/test/browser/page/head.js a=lint-fix

Comment 22

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/6f15878925ca
https://hg.mozilla.org/mozilla-central/rev/d45350ccf8aa
https://hg.mozilla.org/mozilla-central/rev/bf5ac2c3466b

Comment 23

[Ryan VanderMeulen [:RyanVM]]

No need to uplift AFAICT since this suite doesn't run on Beta.

Comment 24

[Intermittent Failures Robot]

30 failures in 4690 pushes (0.006 failures/push) were associated with this bug in the last 7 days.

This is the #22 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• autoland: 18
• try: 7
• mozilla-central: 5

Platform breakdown:

• linux1804-64-asan: 8
• linux1804-64: 14
• linux1804-64-shippable: 6
• linux1804-64-ccov: 1
• windows10-64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1610377&startday=2020-02-10&endday=2020-02-16&tree=all