161046 - Error in the javascript of checking phone number

Status: RESOLVED DUPLICATE of bug 160531

(Core :: DOM: Core & HTML, defect)

Description

[KitKitNet]

They use the following code to validate a international phone number (+44 1234
567890).

http://www.sonyericsson.com/uk/spg.jsp?page=start -> Configurators -> MMS
Configurator -> Anything -> Enter phone number.

If I enter [phone] (standard UK mobile telephone number), it will display
"You must enter a valid phone number". However, if I enter [phone], it
works. Any idea what is the problem of the following code?

If I use Mozilla 1.0 Linux i686 20020623, it will work. Only not working on
Mozilla 1.1b WinXP 2002072104.

<!--
function checkForm(theForm) {
	var num = theForm.mobileNumber.value;
	var checkNum = '+' + parseFloat(num);

	if (num == '' || num.charAt(0) != '+' || num != checkNum) {
		alert('You must enter a valid phone number');
		return false;
	}



	return true;

}

Comment 1

[KitKitNet]

Attachment: Test case for SonyEricsson configurator problem

Following number will not work on the test case:

[phone]
[phone]
[phone]
[phone]

Following number work in the test case:

[phone]
[phone]

Comment 2

[KitKitNet]

BTW, IE 6 on my machine works fine. 

Comment 3

[Phil Schwartau]

Confirming bug with Mozilla trunk binary 20020725xx on WinNT.

STEPS TO REPRODUCE
1. Save the above testcase locally (so the submit() doesn't make Bugzilla mad)
2. Try the string [phone] NO PROBLEM
3. Try the string [phone] BUG!!!


From Mozilla > Tools > Web Development > JavaScript Debugger,
where I stepped through the function checkForm() given above:

num
[string] "[phone]"

parseFloat(num)
[double] 441111111110.:    <<<------------------------- THIS IS THE PROBLEM!

checkNum
[string] "[phone].:"


This is a duplicate of bug 160531. As in that bug, certain numbers
are being corrupted in the browser with a '.:' getting added.

As in the other bug, we see no such corruption in the standalone
JS shell:

js> var num = "[phone]"

js> num
[phone]

js> parseFloat(num);
441111111111


Therefore reassigning to DOM Level 0 before duping -

Comment 4

[Phil Schwartau]

[e-mail]: thank you for this report; you will be
cc'ed on the other bug so you can monitor its progress.

When that bug is marked "Fixed", please re-check your test with a
Mozilla build taken one day after the fix date. If your testcase
still doesn't work, please re-open bug 160531 (not this one). 

*** This bug has been marked as a duplicate of 160531 ***