Closed Bug 1610530 Opened 5 years ago Closed 1 month ago

Use classes instead of ids to access urlbar elements from UrlbarInput

Categories

(Firefox :: Address Bar, task, P3)

Product:
Firefox
Component:
Address Bar
Type:
task
Points:
3

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Future
Tracking Flags:
Tracking Status
firefox128 --- fixed

People

(Reporter: dao, Assigned: mbeier)

References

(Blocks 1 open bug)

Details

(Whiteboard: [sng])

Attachments

(1 file)

Bug 1610530 - Use classes instead of ids to access urlbar elements from UrlbarInput. r?dao
48 bytes, text/x-phabricator-request
Details | Review

urlbar-input
urlbar-input-container
identity-box
urlbar-go-button
urlbar-search-button

These should be converted to classes, so that the search bar can have equivalent elements within the same window. We may need to make access to some of these elements optional as they may not exist in the search bar (e.g. identity-box).

Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Iteration: --- → 76.1 - Mar 9 - Mar 22

I'm postponing this until we know whether the search bar or Firefox Reality are going to reuse UrlbarInput.jsm.

Assignee: dao+bmo → nobody
Status: ASSIGNED → NEW
Iteration: 76.1 - Mar 9 - Mar 22 → ---
Target Milestone: --- → Future
Severity: normal → S3
Assignee: nobody → mbeier
Status: NEW → ASSIGNED
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cd798ae49ef7
Use classes instead of ids to access urlbar elements from UrlbarInput. r=dao,webdriver-reviewers,whimboo
Whiteboard: [sng]

https://hg.mozilla.org/mozilla-central/rev/cd798ae49ef7

Status: ASSIGNED → RESOLVED
Closed: 1 month ago
status-firefox128: --- → fixed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: