1610582 - Firefox requests notification permission with dom.push.testing.ignorePermission enabled

Status: VERIFIED FIXED

(Core :: DOM: Push Subscriptions, defect, P2)

Description

[Jason Kratzer [:jkratzer]]

Firefox prompts for permission to allow notifications even with the pref dom.push.testing.ignorePermission enabled. This is due to the missing return statement at:
https://searchfox.org/mozilla-central/rev/68b2e0fd4323261a229233ec2ab8606228979141/dom/push/Push.jsm#89

Comment 1

[Jason Kratzer [:jkratzer]]

Attachment: Bug 1610582 - Don't prompt for permission if dom.push.testing.ignorePermission enabled

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:jkratzer, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/08149dc0e968
Don't prompt for permission if dom.push.testing.ignorePermission enabled r=lina

Comment 4

[Lina Butler (ex-Mozilla)]

Thanks Jason! 😄

Comment 5

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/08149dc0e968

Comment 6

[Cristian Baica [:cbaica], Release Desktop QA]

Managed to reproduce the issue using Fx74.0a1.
The issue is verified fixed using Fx75.0b5 and Fx76.0a1 on windows 10, macOS and Ubuntu 18.04. There is no prompt displayed for notification permissions. This was tested by toggling the push notifications on/off in twitter settings.