1610613 - Make always-on-top windows persist across workspaces

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect, P3)

Description

[Mike Conley (:mconley) (:⚙️)]

For Picture-in-Picture, we use an always-on-top window to keep the video player on top of other applications.

For users that use workspaces on macOS, this is only a half-measure, since it's easy to lose the player window between workspaces. Ideally, the player window should persist between workspaces.

Chromium is able to do this with their non-native player window, so we can likely leverage the same technique.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:spohl, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[basti]

I just rechecked in latest Dev Edition. The way picture-in-picture is implemented is of no use to a mac user if he is using apps in fullscreen mode and across multiple workspaces.
Picture-in-picture should behave like Helium does. For reference see https://github.com/JadenGeller/Helium

Besides that... Great Feature!

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1610613 - Make Picture-in-Picture window persist across workspaces on macOS. r?spohl!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b293d01619f7
Make Picture-in-Picture window persist across workspaces on macOS. r=spohl

Comment 5

[basti]

I have to add that this is a problem on windows too if you use the virtual desktops.

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/b293d01619f7

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 9138719 [details]
Bug 1610613 - Make Picture-in-Picture window persist across workspaces on macOS. r?spohl!

Beta/Release Uplift Approval Request

• User impact if declined: Users on macOS using Picture-in-Picture not be able to view the player window on multiple virtual desktops simultaneously.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is a very small, well-contained patch that changes a bit on the Picture-in-Picture player window when communicating with macOS. It doesn't effect any other kind of window.
• String changes made/needed: None.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9138719 [details]
Bug 1610613 - Make Picture-in-Picture window persist across workspaces on macOS. r?spohl!

Approved for 76.0b5.

Comment 9

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/releases/mozilla-beta/rev/8ba5a8af8cba