Open Bug 1610684 Opened 5 years ago Updated 3 years ago

ServiceRocket Google Drive Confluence integration doesn't support embedded Google drive links in Confluence in Firefox due to tracking protection

Categories

(Developer Engagement :: Outreach Request, defect)

defect
Not set
normal

Tracking

(Not tracked)

People

(Reporter: ehsan.akhgari, Unassigned)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

This can be seen on https://mana.mozilla.org/wiki/pages/viewpage.action?spaceKey=SE&title=Services+Engineering for example, in Nightly.

What appears to be happening is that ServiceRocket Google Drive Confluence integration is running some code to detect if the user is signed in, otherwise they show a login screen like the one in the attached screenshot.

  1. It turns out that with level 2 content blocking (bug 1501461) https://apis.google.com/js/api.js will get fetched without cookies, so it will have an "isLoggedIn":false variable inside it. It seems to trip over the ServiceRocket code in at least two ways.

If the loaded page has an included page which has an embedded drive inside it (like this one) then intermittently the ServiceRocket code detects that the user is logged out and presents a login UI instead of the embedded Google doc, as in the screenshot.

  1. In this file there is some code like this:
      function f(e) {
        return new S.default(function (t, n) {
          gapi.client.request({
            path: '/drive/v3/files/' + e + '?supportsTeamDrives=true'
          }).then(function () {
            t(Z.VIEW)
          }, function (e) {
            t(gapi.auth2.getAuthInstance().isSignedIn.get() ? Z.NOPERMISSION : Z.NOTLOGIN);
            var r = e.status;
            404 === r && 403 === r || n(e)
          })
        })
      }

When this code runs, gapi.client is undefined, and this throws an exception and results in an error screen. This problem is also intermittent and it sometimes doesn't happen. It can be reproduced on this page.

Peter, is there a chance you could please reach out to ServiceRocket about this? Thanks!

Flags: needinfo?(stpeter)
Blocks: etp-level-2-list
No longer blocks: 1550899
See Also: → 1550899

I resorted to reaching out via the contact form on their website. If that doesn't work, we'll escalate.

Flags: needinfo?(stpeter)
Type: task → defect

The doc linked above is now located at: https://mana.mozilla.org/wiki/display/FDPDT/2020+OKRs.

It looks like this is now completely broken in Firefox (Nightly at least), even with ETP disabled. I'm able to successfully load the embedded doc in Chrome after logging in.

Rachel, would you mind to confirm? If so, we can move this to the webcompat component.

Flags: needinfo?(rtublitz)

Confirmed - Page is still broken in Nightly, even with ETP disabled. Confirmed it works fine in Chrome (ie, renders the linked google sheet).

Flags: needinfo?(rtublitz)

Does anyone still have a page where this issue can be seen?

So I think this reproduces e.g. on https://mana.mozilla.org/wiki/display/FJT/2020+OKRs, however, our Google Drive integration seems broken in general. I'll try to find someone from ServiceDesk to repair that and then we can continue testing.

Filed a request with ServiceDesk to fix it

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: