1610710 - High frequency browser/base/content/test/general/browser_bug767836_perwindowpb.js | A promise chain failed to handle a rejection: (Unable to convert rejection reason to string.) - stack: (No stack available.)

Status: RESOLVED FIXED

(Firefox :: New Tab Page, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: nerli [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=285857028&repo=mozilla-beta
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/GQkA_DR3RTCOTHONhU_TxQ/runs/0/artifacts/public/logs/live_backing.log

---

[task 2020-01-21T23:23:12.326Z] 23:23:12 INFO - TEST-START | browser/base/content/test/general/browser_bug767836_perwindowpb.js
[task 2020-01-21T23:23:13.114Z] 23:23:13 INFO - GECKO(1908) | JavaScript error: resource://gre/modules/XULStore.jsm, line 66: Error: Can't find profile directory.
[task 2020-01-21T23:23:13.231Z] 23:23:13 INFO - GECKO(1908) | JavaScript error: resource://gre/modules/XULStore.jsm, line 66: Error: Can't find profile directory.
[task 2020-01-21T23:23:13.476Z] 23:23:13 INFO - GECKO(1908) | JavaScript error: , line 0: uncaught exception: undefined
[task 2020-01-21T23:23:13.476Z] 23:23:13 INFO - TEST-INFO | started process screentopng
[task 2020-01-21T23:23:13.890Z] 23:23:13 INFO - TEST-INFO | screentopng: exit 0
[task 2020-01-21T23:23:13.890Z] 23:23:13 INFO - Buffered messages logged at 23:23:12
[task 2020-01-21T23:23:13.890Z] 23:23:13 INFO - Entering test bound test_newTabService
[task 2020-01-21T23:23:13.890Z] 23:23:13 INFO - TEST-PASS | browser/base/content/test/general/browser_bug767836_perwindowpb.js | No custom newtab url is set -
[task 2020-01-21T23:23:13.890Z] 23:23:13 INFO - TEST-PASS | browser/base/content/test/general/browser_bug767836_perwindowpb.js | URL of NewTab should be about:newtab in normal mode -
[task 2020-01-21T23:23:13.890Z] 23:23:13 INFO - TEST-PASS | browser/base/content/test/general/browser_bug767836_perwindowpb.js | Custom newtab url is set -
[task 2020-01-21T23:23:13.891Z] 23:23:13 INFO - TEST-PASS | browser/base/content/test/general/browser_bug767836_perwindowpb.js | URL of NewTab should be the custom url -
[task 2020-01-21T23:23:13.891Z] 23:23:13 INFO - TEST-PASS | browser/base/content/test/general/browser_bug767836_perwindowpb.js | No custom newtab url is set -
[task 2020-01-21T23:23:13.891Z] 23:23:13 INFO - Console message: [JavaScript Error: "[Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIControllers.removeController]" nsresult: "0x80004005 (NS_ERROR_FAILURE)" location: "JS frame :: chrome://global/content/elements/browser-custom-element.js :: destroy :: line 1374" data: no]"]
[task 2020-01-21T23:23:13.891Z] 23:23:13 INFO - destroy@chrome://global/content/elements/browser-custom-element.js:1374:28
[task 2020-01-21T23:23:13.892Z] 23:23:13 INFO - disconnectedCallback@chrome://global/content/elements/browser-custom-element.js:408:12
[task 2020-01-21T23:23:13.892Z] 23:23:13 INFO - removePreloadedBrowser@resource:///modules/NewTabPagePreloading.jsm:200:41
[task 2020-01-21T23:23:13.892Z] 23:23:13 INFO - onUnload@chrome://browser/content/browser.js:2448:26
[task 2020-01-21T23:23:13.892Z] 23:23:13 INFO -
[task 2020-01-21T23:23:13.898Z] 23:23:13 INFO - Buffered messages logged at 23:23:13
[task 2020-01-21T23:23:13.900Z] 23:23:13 INFO - Console message: [JavaScript Error: "Error: Can't find profile directory." {file: "resource://gre/modules/XULStore.jsm" line: 66}]
[task 2020-01-21T23:23:13.900Z] 23:23:13 INFO - Console message: [JavaScript Error: "Error: Can't find profile directory." {file: "resource://gre/modules/XULStore.jsm" line: 66}]
[task 2020-01-21T23:23:13.901Z] 23:23:13 INFO - TEST-PASS | browser/base/content/test/general/browser_bug767836_perwindowpb.js | URL of NewTab should be about:privatebrowsing in per window private browsing mode -
[task 2020-01-21T23:23:13.901Z] 23:23:13 INFO - TEST-PASS | browser/base/content/test/general/browser_bug767836_perwindowpb.js | Custom newtab url is set -
[task 2020-01-21T23:23:13.903Z] 23:23:13 INFO - TEST-PASS | browser/base/content/test/general/browser_bug767836_perwindowpb.js | URL of NewTab should be the custom url -
[task 2020-01-21T23:23:13.903Z] 23:23:13 INFO - TEST-PASS | browser/base/content/test/general/browser_bug767836_perwindowpb.js | No custom newtab url is set -
[task 2020-01-21T23:23:13.903Z] 23:23:13 INFO - Buffered messages finished
[task 2020-01-21T23:23:13.904Z] 23:23:13 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_bug767836_perwindowpb.js | A promise chain failed to handle a rejection: (Unable to convert rejection reason to string.) - stack: (No stack available.)
[task 2020-01-21T23:23:13.904Z] 23:23:13 INFO - Rejection date: Tue Jan 21 2020 23:23:13 GMT+0000 (Coordinated Universal Time) - false == true - JS frame :: resource://testing-common/PromiseTestUtils.jsm :: assertNoUncaughtRejections :: line 265
[task 2020-01-21T23:23:13.904Z] 23:23:13 INFO - Stack trace:
[task 2020-01-21T23:23:13.905Z] 23:23:13 INFO - resource://testing-common/PromiseTestUtils.jsm:assertNoUncaughtRejections:265
[task 2020-01-21T23:23:13.905Z] 23:23:13 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1093
[task 2020-01-21T23:23:13.906Z] 23:23:13 INFO - Leaving test bound test_newTabService
[task 2020-01-21T23:23:13.906Z] 23:23:13 INFO - Console message: [JavaScript Error: "uncaught exception: undefined"]
[task 2020-01-21T23:23:13.906Z] 23:23:13 INFO - GECKO(1908) | MEMORY STAT | vsize 3346MB | residentFast 520MB | heapAllocated 266MB
[task 2020-01-21T23:23:13.907Z] 23:23:13 INFO - TEST-OK | browser/base/content/test/general/browser_bug767836_perwindowpb.js | took 1152ms
[task 2020-01-21T23:23:13.907Z] 23:23:13 INFO - checking window state
[task 2020-01-21T23:23:13.908Z] 23:23:13 INFO - GECKO(1908) | must wait for focus

Comment 1

[Noemi Erli[:noemi_erli]]

Could this be a regression from 1607937?

Comment 2

[Mike Kaply [:mkaply]]

No, that bug wouldn't have affected this. It's policy only and only related to addons.

Comment 3

[Intermittent Failures Robot]

3 failures in 4004 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-beta: 3

Platform breakdown:

• linux64-shippable: 3

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1610710&startday=2020-01-20&endday=2020-01-26&tree=all

Comment 4

[Intermittent Failures Robot]

1 failures in 3364 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 1

Platform breakdown:

• linux64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1610710&startday=2020-02-03&endday=2020-02-09&tree=all

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

https://wiki.mozilla.org/Bug_Triage#Intermittent_Test_Failure_Cleanup
For more information, please visit auto_nag documentation.

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

This is still happening.

Recent failure: https://treeherder.mozilla.org/logviewer?job_id=322914268&repo=autoland&lineNumber=2280

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 8

[Intermittent Failures Robot]

5 failures in 1479 pushes (0.003 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 5

Platform breakdown:

• windows10-64: 2
• linux1804-64: 1
• linux1804-64-asan: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1610710&startday=2020-11-23&endday=2020-11-29&tree=all

Comment 9

[Intermittent Failures Robot]

34 failures in 787 pushes (0.043 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 28
• mozilla-central: 6

Platform breakdown:

• linux1804-64: 9
• windows10-64: 7
• linux1804-64-asan: 8
• linux1804-64-tsan: 8
• linux1804-64-shippable: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1610710&startday=2020-12-02&endday=2020-12-02&tree=all

Comment 10

[Razvan Maries]

It seems that the frequency has been increased: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Crunnable&fromchange=3f6e90beb51e4ada67566132ae93f028e59dee38&searchStr=linux%2C18.04%2Cx64%2Cdebug%2Cmochitests%2Ctest-linux1804-64%2Fdebug-mochitest-browser-chrome-e10s%2Cbc4&selectedTaskRun=Jnsi7zcwTbWP7q_TGdmK7A.1

Comment 11

[Andreea Pavel [:apavel]]

Retriggers: https://treeherder.mozilla.org/jobs?repo=autoland&test_paths=browser%2Fbase%2Fcontent%2Ftest%2Fgeneral%2F&tochange=08cd8d747c33ab8d092ea6de2aac565e79093b3e&fromchange=1c8480affdfd71eeced35da2b6acf3d8b36f0523&searchStr=Windows%2C10%2Cx64%2Casan&group_state=expanded

https://treeherder.mozilla.org/jobs?repo=autoland&searchStr=Windows%2C10%2Cx64%2Casan%2CMochitests%2Ctest-windows10-64-asan%2Fopt-mochitest-browser-chrome-e10s%2Cbc1&tochange=08cd8d747c33ab8d092ea6de2aac565e79093b3e&fromchange=1c8480affdfd71eeced35da2b6acf3d8b36f0523&group_state=expanded

Robert, could bug 1645528 have caused a failure increase here?

Comment 12

[Intermittent Failures Robot]

74 failures in 651 pushes (0.114 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 67
• mozilla-central: 6
• try: 1

Platform breakdown:

• linux1804-64-tsan: 19
• windows10-64: 9
• linux1804-64-asan: 12
• linux1804-64: 31
• linux1804-64-ccov: 2
• linux1804-64-devedition: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1610710&startday=2020-12-03&endday=2020-12-03&tree=all

Comment 13

[Robert Mader [:rmader]]

Yes, that can indeed be the case. However, there're reasons assume that the patch is not "at fault" :)

After bug 1645528 the order and exact timing of when certain events fire might have changed. All tests that are "flaky" in the sense that they rely on implicit, or rather invalid, assumptions about the timing may change for the better or worse - see for example bug 1602701, which now almost perma-fails on X11. In that case bug, however, it was already known that the test did not use the appropriate method to wait for things to happen.

Given that this issue is not new and the fact that until now the failure rate seems to be in the 10-15% range, I suppose there's a good chance that it is timing-sensitive as well. If there was something actionable about bug 1645528 I'd assume to see way more test starting to spike, as it affects all platforms in a quite central place.

So from my site I'd recommend having a closer look at the test itself, rather than bug 1645528.

Comment 14

[Intermittent Failures Robot]

47 failures in 708 pushes (0.066 failures/push) were associated with this bug yesterday.

** This test has failed more than 150 times in the last 21 days. It should be disabled until it can be fixed. **

Repository breakdown:

• autoland: 38
• try: 6
• mozilla-central: 3

Platform breakdown:

• linux1804-64-tsan: 12
• linux1804-64: 16
• windows10-64: 7
• linux1804-64-asan: 10
• linux1804-64-ccov: 1
• linux1804-64-shippable: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1610710&startday=2020-12-04&endday=2020-12-04&tree=all

Comment 15

[Cosmin Sabou [:CosminS]]

Attachment: Bug 1610710 - Disable browser_bug767836_perwindowpb.js on linux and win asan. r=#intermittent-reviewers

Comment 16

[Cosmin Sabou [:CosminS]]

Scott, could you redirect this to someone to take a look over this flaky test. It has:

• 162 total failures in the last 30 days: https://treeherder.mozilla.org/intermittent-failures/bugdetails?startday=2020-11-28&endday=2020-12-05&tree=trunk&bug=1610710

Recent failure log: https://treeherder.mozilla.org/logviewer?job_id=323664233&repo=autoland&lineNumber=2573
Meanwhile I've disabled this on linux and windows asan because of the high failure rate.
Thank you.

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/489c19245ebc
Disable browser_bug767836_perwindowpb.js on linux and win asan. r=intermittent-reviewers,jmaher DONTBUILD

Comment 18

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/489c19245ebc

Comment 19

[Intermittent Failures Robot]

167 failures in 3712 pushes (0.045 failures/push) were associated with this bug in the last 7 days.

This is the #2 most frequent failure this week.

** This failure happened more than 75 times this week! Resolving this bug is a very high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 1 week, the affected test(s) may be disabled. **

Repository breakdown:

• autoland: 143
• mozilla-central: 16
• try: 8

Platform breakdown:

• linux1804-64: 59
• linux1804-64-asan: 32
• windows10-64: 27
• linux1804-64-tsan: 42
• linux1804-64-shippable: 3
• linux1804-64-ccov: 3
• linux1804-64-devedition: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1610710&startday=2020-11-30&endday=2020-12-06&tree=all

Comment 20

[Scott [:thecount] Downe]

Attachment: Bug 1610710 - Potential fix to a failing unit test, A promise chain failed to handle a rejection.

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/58cc9db51ef9
Potential fix to a failing unit test, A promise chain failed to handle a rejection. r=Gijs

Comment 22

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/58cc9db51ef9

Comment 23

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7e64b7127814
Re-enable the test as a fix for it landed. a=test-only DONTBUILD

Comment 24

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/7e64b7127814

Comment 25

[Intermittent Failures Robot]

1 failures in 4060 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

** This test has failed more than 150 times in the last 21 days. It should be disabled until it can be fixed. **

Repository breakdown:

• try: 1

Platform breakdown:

• linux1804-64-asan: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1610710&startday=2020-12-07&endday=2020-12-13&tree=all

Comment 26

[:Gijs (he/him)]

Can we re-enable the test on linux/win asan?

Comment 27

[Andreea Pavel [:apavel]]

(In reply to :Gijs (he/him) from comment #26)

Can we re-enable the test on linux/win asan?

The test is enabled on all platforms: https://searchfox.org/mozilla-central/source/browser/base/content/test/general/browser.ini#177