1610732 - Stop using NS_ERROR_DOM_TYPE_ERR in webauthn

Status: RESOLVED FIXED

(Core :: DOM: Web Authentication, task)

Description

[Boris Zbarsky [:bzbarsky]]

It makes us throw incorrect exceptions.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1610732 part 1. Switch some webauthn tests to non-legacy promise_rejects_* functions. r=jcj

This is needed so we can actually test the fix for the bug we're fixing.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1610732 part 2. Throw the right exception when a user.id value is too long. r=jcj

The test changes are for the following reasons:

1. Removing the "empty ArrayBuffer" test: I don't see anything obvious in the
   spec that would cause that to reject before prompting the user, and in fact it
   does not do that in browsers. All browsers time out on that line.

2. Removing the "name is object" test: This test is wrong. Passing {} where a
   string is expected in IDL will come out as the string "[object Object]" on the
   other side, and that seems like a perfectly valid name.

3. Removing the "name is null" test: This test is wrong. Passing null where a
   string is expected in IDL will come out as the string "null" on the other side,
   and that seems like a perfectly valid name.

4. Removing the "name is empty" test: I don't see anything obvious in the
   spec that would cause that to reject before prompting the user.

5. Removing the various "icon is whatever" tests: I don't see anything obvious in the
   spec that would cause that to reject before prompting the user.

6. Removing the various "displayName is whatever" tests: the same reasoning as
   for the coresponding "name is whatever" tests applies.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/42547ab8bb61
part 1.  Switch some webauthn tests to non-legacy promise_rejects_* functions.  r=jcj
https://hg.mozilla.org/integration/autoland/rev/274fbf05b895
part 2.  Throw the right exception when a user.id value is too long.  r=jcj

Comment 4

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/21348 for changes under testing/web-platform/tests

Comment 5

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Can't merge web-platform-tests PR due to failing upstream checks:
Github PR https://github.com/web-platform-tests/wpt/pull/21348
* Community-TC (pull_request) (https://community-tc.services.mozilla.com/tasks/groups/Q_QCZkDMTtae9legE4hZ0A)

Comment 6

[Boris Zbarsky [:bzbarsky]]

See https://github.com/web-platform-tests/wpt/pull/21348#issuecomment-577340367 -- the webauthn tests are all mostly broken and time out in all browsers; this change is not affecting that, apart from making one of them not time out.

Comment 7

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/42547ab8bb61
https://hg.mozilla.org/mozilla-central/rev/274fbf05b895

Comment 8

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by jgraham