1610750 - Remove some nsIEditor methods which are used by neither m-c, c-c nor BlueGriffon

Status: RESOLVED FIXED

(Core :: DOM: Editor, task, P5)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Obviously, the following methods of nsIEditor is not used by Gecko embedded products (I'm not sure about XUL addons for Thunderbird and SeaMonkey though).

• getAttributeValue c-c BG
• cloneAttribute c-c BG
• splitNode c-c BG
• joinNodes c-c BG
• markNodeDirty c-c BG
• removeEditorObserver c-c BG

We should just remove them from nsIEditor interface.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1610750 - Get rid of unused `nsIEditor` methods r=m_kato!

• getAttributeValue
• cloneAttribute
• splitNode
• joinNodes
• markNodeDirty
• removeEditorObserver

are not used from script. Therefore, we can get rid of them from nsIEditor.

However, EditorBase::GetAttributeValue() is referred by
HTMLEditor::CopyCellBackgroundColor() and it's just a wrapper of
Element::GetAttr(). Therefore, this patch makes
HTMLEditor::CopyCellBackgroundColor() use Element::GetAttr() directly.

And also EditorBase::MarkNodeDirty() is used from some friend classes.
Therefore, this patch redesigns it as MarkElementDirty() and make all of
them check whether the method call destroys the editor.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a170089a8a03
Get rid of unused `nsIEditor` methods r=m_kato

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/a170089a8a03

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1610750 - Remove unused scriptable methods of `nsIHTMLEditor`, `nsIEditorStyleSheets` and `nsITableEditor` r=m_kato!

• nsIHTMLEditor.removeAllInlineProperties
• nsIHTMLEditor.increaseFontSize
• nsIHTMLEditor.decreaseFontSize
• nsIHTMLEditor.setParagraphFormat
• nsIHTMLEditor.getBackgroundColorState
• nsIHTMLEditor.indent
• nsIHTMLEditor.align
• nsIEditorStyleSheets.replaceOverrideStyleSheet
• nsITableEditor.selectBlockOfCells

These methods are not used by any Gecko products including comm-central and
BlueGriffon so that we should remove them. Note that only
HTMLEditor::GetBackgroundColorState() is used internally so that we need to
keep it as a public method of HTMLEditor.

Comment 5

[Phabricator Automation]

Comment on attachment 9123232 [details]
Bug 1610750 - Remove unused scriptable methods of nsIHTMLEditor, nsIEditorStyleSheets and nsITableEditor r=m_kato!

Revision D61139 was moved to bug 1611751. Setting attachment 9123232 [details] to obsolete.