1610833 - Autocomplete fails after `/(`

Status: RESOLVED FIXED

(DevTools :: Console, defect, P3)

Description

[Nicolas Chevobbe [:nchevobbe]]

Steps to reproduce

1. Open the console
2. Type 1/(d

Expected results

The autocomplete popup should be displayed, containing document

Actual results

The autocomplete popup isn't displayed.

Comment 1

[Pranav pandey]

hi 👋 ,
I look into it and found that if you type /( https://searchfox.org/mozilla-central/source/devtools/client/webconsole/actions/autocomplete.js#145) this will do autocomplete for '(' and filled in the with matches = [] instead of matches = null which inturn fills cache(https://searchfox.org/mozilla-central/source/devtools/client/webconsole/reducers/autocomplete.js#50), so if after that you write anything (https://searchfox.org/mozilla-central/source/devtools/client/webconsole/actions/autocomplete.js#145) this is called as cache is empty we don't get any result, I cannot find the implementation of autocomplete method used here(https://searchfox.org/mozilla-central/source/devtools/client/webconsole/actions/autocomplete.js#145) can you point me into it so I could investigate further

Thanx
Pranav

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

hello Pranav, thanks for investigating.

I don't think the issue is on the client side.
If you apply the following diff:

diff --git a/devtools/shared/webconsole/test/xpcshell/test_js_property_provider.js b/devtools/shared/webconsole/test/xpcshell/test_js_property_provider.js
--- a/devtools/shared/webconsole/test/xpcshell/test_js_property_provider.js
+++ b/devtools/shared/webconsole/test/xpcshell/test_js_property_provider.js
@@ -594,6 +594,9 @@ function runChecks(dbgObject, environmen
   });
   test_has_result(results, "'propA'");
   Assert.equal(results.matches.has("propLocal"), false);
+
+  results = propertyProvider("1/(t");
+  test_has_result(results, "testObject");
 }

and run the test, it will fail.
This means there's an issue with JsPropertyProvider analyzeInputString (devtools/shared/webconsole/js-property-provider.js#412 )

The culprit is probably here https://searchfox.org/mozilla-central/rev/ad6234148892bc29bf08d736604ac71925138040/devtools/shared/webconsole/js-property-provider.js#544-547, where we reset the statement, but really should go other the normal case.

Comment 3

[Miguel Roncancio]

I'd like to work on this!

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Thanks Miguel, it's yours :)
Let me know if you have any question

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months.
:nchevobbe, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 6

[cpplearner]

Attachment: WIP: Bug 1610833 - Autocomplete fails after `/(`

Comment 7

[cpplearner]

Attachment: Bug 1610833 - Autocomplete fails after `/(` r=#devtools-reviewers

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/da119eca293c
Fix console autocomplete after `/(` . r=devtools-reviewers,nchevobbe

Comment 9

[Atila Butkovits]

Backed out for causing linting failures.

Backout link: https://hg.mozilla.org/integration/autoland/rev/f72ab01ea433c5eed76302eb9db9722d25ba932b

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=da119eca293ca23eb3fddb9331535d280fb97770&selectedTaskRun=HgiRWtl9RnuwyOhsjMUvvA.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=493247754&repo=autoland&lineNumber=597

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/767f601556d9
Autocomplete fails after `/(`

Comment 11

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/767f601556d9