1610881 - Stop using NS_ERROR_DOM_TYPE_ERR in payments code

Status: RESOLVED FIXED

(Core :: DOM: Web Payments, task, P3)

Description

[Boris Zbarsky [:bzbarsky]]

PaymentRequest::Constructor has:

  RefPtr<PaymentRequest> request;
  nsresult rv = manager->CreatePayment(aGlobal.Context(), window,
                                       topLevelPrincipal, aMethodData, aDetails,
                                       aOptions, getter_AddRefs(request));
  if (NS_WARN_IF(NS_FAILED(rv))) {
    aRv.Throw(NS_ERROR_DOM_TYPE_ERR);

I don't know what spec step this corresponds to and why the error-throwing is not done on an ErrorResult in CreatePayment, but this code is wrong: there's never a time when throwing NS_ERROR_DOM_TYPE_ERR is the right thing to do. If a TypeError is supposed to be thrown, that needs to use ThrowTypeError.

It doesn't seem like there's any test coverage for this, by the way. Certainly https://coverage.moz.tools/#revision=latest&path=dom%2Fpayments%2FPaymentRequest.cpp&view=file claims this code (as well as many other error-handling cases in PaymentRequest::Constructor, including ones that are easily testable from JS) is not reached...

I can try to disentangle the error-reporting here, so I can make progress on bug 1581172, but it might be better if someone more familiar with this code took a look.

Comment 1

[Eden Chuang[:edenchuang]]

Sorry, will be working on it.

Comment 2

[Boris Zbarsky [:bzbarsky]]

No need to apologize, and thank you!

Comment 3

[Eden Chuang[:edenchuang]]

Attachment: Bug 1610881 - Get rid of ErrorResult.Throw(DOMException) in Payment code

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/03b87e4336e5
Get rid of ErrorResult.Throw(DOMException) in Payment code r=bzbarsky

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/03b87e4336e5