1610914 - Extensions with theme_icons crash in the Icon code

Status: RESOLVED FIXED

(GeckoView :: Extensions, defect)

Description

[[ex-Mozilla] Agi Sferro | :agi]

We see this crash on on the nightly migration build:

java.lang.ClassCastException: org.mozilla.gecko.util.GeckoBundle cannot be cast to java.lang.String
    at org.mozilla.gecko.util.GeckoBundle.getString(GeckoBundle.java:3)
    at org.mozilla.gecko.util.GeckoBundle.getString(GeckoBundle.java:4)
    at org.mozilla.geckoview.WebExtension$Icon.<init>(WebExtension.java:8)
    at org.mozilla.geckoview.WebExtension$Action.<init>(WebExtension.java:12)
    at org.mozilla.geckoview.WebExtensionController.lambda$actionUpdate$15$WebExtensionController(WebExtensionController.java:3)
    at org.mozilla.geckoview.-$$Lambda$WebExtensionController$g1kd-9eaSZhP8v-L5ZIkrSSwVHg.accept
    at org.mozilla.geckoview.GeckoResult.lambda$accept$0(GeckoResult.java:1)
    at org.mozilla.geckoview.-$$Lambda$GeckoResult$I3k4K0DCRrX6z4p5VGaRoaRBTZM.onValue
    at org.mozilla.geckoview.GeckoResult.lambda$thenInternal$2$GeckoResult(GeckoResult.java:2)
    at org.mozilla.geckoview.-$$Lambda$GeckoResult$gwCgOUK_EYQn2g6GolfZvo6A_WE.run
    at android.os.Handler.handleCallback(Handler.java:790)
    at android.os.Handler.dispatchMessage(Handler.java:99)
    at android.os.Looper.loop(Looper.java:164)
    at android.app.ActivityThread.main(ActivityThread.java:6651)
    at java.lang.reflect.Method.invoke(Method.java)
    at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:438)
    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:810)

org.mozilla.geckoview.UncaughtException: java.lang.ClassCastException: org.mozilla.gecko.util.GeckoBundle cannot be cast to java.lang.String
    at org.mozilla.geckoview.GeckoResult.dispatchLocked(GeckoResult.java:4)
    at org.mozilla.geckoview.GeckoResult.completeExceptionally(GeckoResult.java:4)
    at org.mozilla.geckoview.GeckoResult.lambda$thenInternal$2$GeckoResult(GeckoResult.java:10)
    at org.mozilla.geckoview.-$$Lambda$GeckoResult$gwCgOUK_EYQn2g6GolfZvo6A_WE.run
    at android.os.Handler.handleCallback(Handler.java:790)
    at android.os.Handler.dispatchMessage(Handler.java:99)
    at android.os.Looper.loop(Looper.java:164)
    at android.app.ActivityThread.main(ActivityThread.java:6651)
    at java.lang.reflect.Method.invoke(Method.java)
    at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:438)
    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:810)

Looks like we don't handle theme_icons well.

Comment 1

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1610914 - Handle theme_icons in Icon.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/03aa8dbc3ae9
Handle theme_icons in Icon. r=snorp

Comment 3

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/03aa8dbc3ae9