Closed Bug 1610975 Opened 2 years ago Closed 2 years ago

Socket process enabled locally, but not on try server for android

Categories

(Core :: Networking, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla75
Tracking Status
firefox75 --- fixed

People

(Reporter: bdahl, Assigned: bwc)

References

(Blocks 1 open bug)

Details

(Whiteboard: [necko-triaged])

Attachments

(1 file)

As mentioned here, when running mochitests locally the socket process is enabled for android. However, on try the socket process is disabled. This leads to discrepancies locally and on try and caused us to miss the linked bug.

Can we unify this setting so further problems aren't missed?

Flags: needinfo?(kershaw)

Having a separate socket process variant for jobs on try ("spi") was a deliberate choice, since we wanted to ensure that both cases were tested. I guess any default we pick for local builds is not going to cover everything that runs in try.

It doesn't look like "spi" is running on android.

Ni self to look into this.

Flags: needinfo?(docfaraday)
Blocks: socket-proc
Flags: needinfo?(kershaw)
Priority: -- → P3
Whiteboard: [necko-triaged]

It looks like M-spi is also not running on linux64.

Edit: Actually, those jobs are for binary building only, but also run some browser-chrome mochitests? Weird.

So I guess we need to modify this stuff:

https://searchfox.org/mozilla-central/rev/2e355fa82aaa87e8424a9927c8136be184eeb6c7/taskcluster/ci/test/mochitest.yml#284-288

It might break android testing that does not use e10s though. I can try once hg is back up again...

Assignee: nobody → docfaraday
Flags: needinfo?(docfaraday)

Um. The mda mochitests aren't running on android emulator at all. Since the mda tests are the only things that run on try with the socket process, even enabling the socketprocess variant on android does not result in M-spi jobs being scheduled...

Try push looks ok, although there's an intermittent in a try push for bug 1613690. Looking into it.

Depends on: 1613690

Ok, have resolved the issue mentioned in comment 11. Try looks good now.

Hey, heads up -- we want to disable the socket server by default on Android (bug 1612961). You'll want to enable the network.process.enabled pref for the socketserver runs.

(In reply to James Willcox (:snorp) (jwillcox@mozilla.com) (he/him) from comment #16)

Hey, heads up -- we want to disable the socket server by default on Android (bug 1612961). You'll want to enable the network.process.enabled pref for the socketserver runs.

We go to great lengths to ensure that the socket process is enabled in CI if and only if we're running an spi job, so changes to defaults shouldn't be a problem for us I think.

Pushed by bcampen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d11722b13bde
Enable socketprocess mochitests on android. r=jmaher
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla75
You need to log in before you can comment on or make changes to this bug.