Open Bug 1611032 Opened 5 years ago Updated 2 years ago

Disable APZ if AccessibleCaret is in position:sticky elements which stick to the root scroller on environments that the toolbar is dynamic

Categories

(Core :: DOM: Selection, task)

Product:
Core
Component:
DOM: Selection
Type:
task

Tracking

()

People

(Reporter: hiro, Unassigned)

References

(Blocks 1 open bug)

Details

In bug 1526268, we disabled APZ for position:fixed elements, we also need the same hack for position:sticky elements, as far as I can tell.

Once caveat as of now is that position:sticky elements don't stick to the dynamic toolbar yet (bug 1594451), so you don't probably see any issues on GeckoView applications.

See Also: → 1594451
Summary: Disable APZ if AccessibleCaret is in position:sticky elements on environments that the toolbar is dynamic → Disable APZ if AccessibleCaret is in position:sticky elements which stick to the root scroller on environments that the toolbar is dynamic
Type: defect → task

bug 1526268 was designed with position:sticky in mind, but the solution is not perfect. See https://phabricator.services.mozilla.com/D51351?id=184974#inline-312215 for the rationale.

Hiro, if what describes in comment 1 becomes a reality, could you provide an STR or example so that we can fix this issue in a sensible manner?

Yeah, I can provide. But unfortunately it requires modified reference-browser (or Fenix). Anyway a STR is;

  1. Open https://www.theguardian.com/
  2. Select some text in a bottom banner about privacy
  3. Scroll down

To build the modified reference-browser;

  1. Clone https://github.com/mozilla-mobile/reference-browser
  2. Apply https://github.com/mozilla-mobile/reference-browser/pull/954 (this PR was merged once but backed out for unknown reasons unfortunately)
  3. Build reference-browser (I hope all you have to do is '/gradlew assembleGeckoNightly', but not 100% sure)

(In reply to Hiroyuki Ikezoe (:hiro) from comment #3)

  1. Open https://www.theguardian.com/
  2. Select some text in a bottom banner about privacy
  3. Scroll down

Hello. FYI, the steps may no longer work, because it was worked around: https://github.com/guardian/dotcom-rendering/pull/1978 (and one linked from there).
+1 for proper fix.

Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.