Closed Bug 1611039 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 21362 - Add tests of the recalculation of 'ch' in pseudo elements

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla74
Tracking Flags:
Tracking Status
firefox74 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 21362 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/21362
Details from upstream follow.

Xiaocheng Hu <xiaochengh@chromium.org> wrote:

Add tests of the recalculation of 'ch' in pseudo elements

Length unit 'ch' should be recalculated after loading a web font. This
patch is a followup of crrev.com/c/1972815 to ensure that it's also
recalculated in pseudo elements.

Bug: 441925
Change-Id: Ie62dba854aa9d1beb6b9a734f31760abf1acd040
Reviewed-on: https://chromium-review.googlesource.com/2016198
WPT-Export-Revision: 01850e267eda02027b8251d0ede60161d5b7d45d

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 42 tests

Status Summary

Firefox

OK : 1
PASS: 41
FAIL: 5

Chrome

OK : 1
PASS: 5

Safari

OK : 1
FAIL: 5

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-values/ch-pseudo-recalc-on-font-load.html
ch in pseudo-element ::after should be recalculated after loading a web font: FAIL (Chrome: PASS, Safari: FAIL)
ch in pseudo-element ::first-letter should be recalculated after loading a web font: FAIL (Chrome: PASS, Safari: FAIL)
ch in pseudo-element ::marker should be recalculated after loading a web font: FAIL (Chrome: PASS, Safari: FAIL)
ch in pseudo-element ::before should be recalculated after loading a web font: FAIL (Chrome: PASS, Safari: FAIL)
ch in pseudo-element ::first-line should be recalculated after loading a web font: FAIL (Chrome: PASS, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2658757418c3
[wpt PR 21362] - Add tests of the recalculation of 'ch' in pseudo elements, a=testonly
https://hg.mozilla.org/integration/autoland/rev/dec7793f0e4a
[wpt PR 21362] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/2658757418c3
https://hg.mozilla.org/mozilla-central/rev/dec7793f0e4a

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox74: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
You need to log in before you can comment on or make changes to this bug.