1611053 - Add profiler marker for XPCJSContext::InterruptScript

Status: RESOLVED FIXED

(Core :: Gecko Profiler, enhancement, P3)

Description

[Jim Porter (:squib)]

Currently, there's no profile marker emitted for XPCJSContext::InterruptScript. There are a few situations where it'd be helpful to see the presence (or absence!) of this call: when debugging long-running JS that you'd expect to trigger the slow script notification, or to identify if InterruptScript is correlated with any other perf issues. In particular, this would be useful for helping to diagnose bug 1606386, especially comment 9.

Comment 1

[Jim Porter (:squib)]

Attachment: Bug 1611053 - Add profiler marker for XPCJSContext::InterruptScript; r?gerald

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:squib, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 3

[Jim Porter (:squib)]

Whoops, I got pulled over onto Fenix stuff and this slipped off my radar! I'll try to get this landed in the next day or so...

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/05881652e940
Add profiler marker for XPCJSContext::InterruptScript; r=gerald

Comment 5

[Andreea Pavel [:apavel]]

Backed out for test crashes

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=293119189&resultStatus=testfailed%2Cbusted%2Cexception&revision=05881652e9406c4ae2a2609f7c1d40c6efcf11ef&failure_classification_id=2

Failure log: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=293119189&resultStatus=testfailed%2Cbusted%2Cexception&revision=05881652e9406c4ae2a2609f7c1d40c6efcf11ef&failure_classification_id=2

and https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=293118936&repo=autoland&lineNumber=4348

Backout: https://hg.mozilla.org/integration/autoland/rev/73fb48251c2a401447e3abc1c8fd88f6adc3016b

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/df5cc0983031
Add profiler marker for XPCJSContext::InterruptScript; r=gerald

Comment 7

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/df5cc0983031

Comment 8

[Jim Porter (:squib)]

Forgot to clear the needinfo when this re-landed...