Closed Bug 1611132 Opened 4 years ago Closed 4 years ago

Perma TEST-UNEXPECTED-FAIL | accessible/tests/browser/events/browser_test_focus_urlbar.js | Test timed out - when Gecko 74 merges to Beta on 2020-02-10

Categories

(Core :: Disability Access APIs, defect)

Product:
Core
Component:
Disability Access APIs
Type:
defect
Priority:
Not set
Severity:
normal
Points:
3

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla74
Iteration:
74.2 - Jan 20 - Feb 09
Tracking Flags:
Tracking Status
firefox-esr68 --- unaffected
firefox72 --- unaffected
firefox73 --- unaffected
firefox74 + verified

People

(Reporter: malexandru, Assigned: adw)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Bug 1611132 - Don't select the heuristic result if there's already a selection.
47 bytes, text/x-phabricator-request
Details | Review

Central as Beta simulation: https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=286123470&resultStatus=success%2Ctestfailed%2Cbusted%2Cexception%2Crunnable&revision=ebae107ff41cb9dd9b4aa92eaae0c5d6a50aa82d&searchStr=%28bc&group_state=expanded

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=286123470&repo=try&lineNumber=1708

[task 2020-01-23T11:19:45.521Z] 11:19:45 INFO - TEST-PASS | accessible/tests/browser/events/browser_test_focus_urlbar.js | Selected element must be selectable! -
[task 2020-01-23T11:19:45.521Z] 11:19:45 INFO - Ensuring focus of another autocomplete item on up arrow
[task 2020-01-23T11:19:45.522Z] 11:19:45 INFO - TEST-PASS | accessible/tests/browser/events/browser_test_focus_urlbar.js | Recieved focus event -
[task 2020-01-23T11:19:45.522Z] 11:19:45 INFO - TEST-PASS | accessible/tests/browser/events/browser_test_focus_urlbar.js | wrong state bits for [DOM node id: urlbarView-row-0, role: combobox option, name: 'http:// example1.com / — Visit', address: [xpconnect wrapped nsIAccessible]]! -
[task 2020-01-23T11:19:45.522Z] 11:19:45 INFO - TEST-PASS | accessible/tests/browser/events/browser_test_focus_urlbar.js | Focussed [DOM node id: urlbarView-row-0, role: combobox option, name: 'http:// example1.com / — Visit', address: [xpconnect wrapped nsIAccessible]] must be focusable! -
[task 2020-01-23T11:19:45.522Z] 11:19:45 INFO - TEST-PASS | accessible/tests/browser/events/browser_test_focus_urlbar.js | Selected element must be selectable! -
[task 2020-01-23T11:19:45.522Z] 11:19:45 INFO - Ensuring text box focus on left arrow
[task 2020-01-23T11:19:45.523Z] 11:19:45 INFO - TEST-PASS | accessible/tests/browser/events/browser_test_focus_urlbar.js | Recieved focus event -
[task 2020-01-23T11:19:45.523Z] 11:19:45 INFO - TEST-PASS | accessible/tests/browser/events/browser_test_focus_urlbar.js | wrong state bits for [DOM node id: urlbar-input, role: entry, name: 'Search with Google or enter address', address: [xpconnect wrapped nsIAccessible]]! -
[task 2020-01-23T11:19:45.523Z] 11:19:45 INFO - TEST-PASS | accessible/tests/browser/events/browser_test_focus_urlbar.js | Focussed [DOM node id: urlbar-input, role: entry, name: 'Search with Google or enter address', address: [xpconnect wrapped nsIAccessible]] must be focusable! -
[task 2020-01-23T11:19:45.523Z] 11:19:45 INFO - TEST-PASS | accessible/tests/browser/events/browser_test_focus_urlbar.js | Singleline [DOM node id: urlbar-input, role: entry, name: 'Search with Google or enter address', address: [xpconnect wrapped nsIAccessible]] cannot be multiline! -
[task 2020-01-23T11:19:45.524Z] 11:19:45 INFO - TEST-PASS | accessible/tests/browser/events/browser_test_focus_urlbar.js | Collapsed or expanded [DOM node id: urlbar-input, role: entry, name: 'Search with Google or enter address', address: [xpconnect wrapped nsIAccessible]] must be expandable! -
[task 2020-01-23T11:19:45.527Z] 11:19:45 INFO - TEST-PASS | accessible/tests/browser/events/browser_test_focus_urlbar.js | Expanded [DOM node id: urlbar-input, role: entry, name: 'Search with Google or enter address', address: [xpconnect wrapped nsIAccessible]] cannot be collapsed! -
[task 2020-01-23T11:19:45.527Z] 11:19:45 INFO - Ensuring autocomplete focus on down arrow (2)
[task 2020-01-23T11:19:45.527Z] 11:19:45 INFO - TEST-PASS | accessible/tests/browser/events/browser_test_focus_urlbar.js | Recieved focus event -
[task 2020-01-23T11:19:45.527Z] 11:19:45 INFO - TEST-PASS | accessible/tests/browser/events/browser_test_focus_urlbar.js | wrong state bits for [DOM node id: urlbarView-row-0, role: combobox option, name: 'http:// example1.com / — Visit', address: [xpconnect wrapped nsIAccessible]]! -
[task 2020-01-23T11:19:45.527Z] 11:19:45 INFO - TEST-PASS | accessible/tests/browser/events/browser_test_focus_urlbar.js | Focussed [DOM node id: urlbarView-row-0, role: combobox option, name: 'http:// example1.com / — Visit', address: [xpconnect wrapped nsIAccessible]] must be focusable! -
[task 2020-01-23T11:19:45.527Z] 11:19:45 INFO - TEST-PASS | accessible/tests/browser/events/browser_test_focus_urlbar.js | Selected element must be selectable! -
[task 2020-01-23T11:19:45.528Z] 11:19:45 INFO - Ensuring autocomplete focus on arrow up for search settings button
[task 2020-01-23T11:19:45.528Z] 11:19:45 INFO - Buffered messages finished
[task 2020-01-23T11:19:45.544Z] 11:19:45 INFO - TEST-UNEXPECTED-FAIL | accessible/tests/browser/events/browser_test_focus_urlbar.js | Test timed out -
[task 2020-01-23T11:19:45.545Z] 11:19:45 INFO - GECKO(1127) | MEMORY STAT | vsize 20975065MB | residentFast 1143MB
[task 2020-01-23T11:19:45.545Z] 11:19:45 INFO - TEST-OK | accessible/tests/browser/events/browser_test_focus_urlbar.js | took 90202ms
[task 2020-01-23T11:19:45.546Z] 11:19:45 INFO - checking window state
[task 2020-01-23T11:19:45.547Z] 11:19:45 INFO - TEST-START | accessible/tests/browser/events/browser_test_scrolling.js
[task 2020-01-23T11:19:46.112Z] 11:19:46 INFO - GECKO(1127) | MEMORY STAT | vsize 20975071MB | residentFast 1066MB
[task 2020-01-23T11:19:46.112Z] 11:19:46 INFO - TEST-OK | accessible/tests/browser/events/browser_test_scrolling.js | took 741ms
[task 2020-01-23T11:19:46.156Z] 11:19:46 INFO - checking window state
[task 2020-01-23T11:19:46.196Z] 11:19:46 INFO - TEST-START | accessible/tests/browser/events/browser_test_textcaret.js
[task 2020-01-23T11:19:47.063Z] 11:19:47 INFO - GECKO(1127) | MEMORY STAT | vsize 20975077MB | residentFast 1087MB
[task 2020-01-23T11:19:47.064Z] 11:19:47 INFO - TEST-OK | accessible/tests/browser/events/browser_test_textcaret.js | took 862ms
[task 2020-01-23T11:19:47.108Z] 11:19:47 INFO - checking window state
[task 2020-01-23T11:19:47.108Z] 11:19:47 INFO - GECKO(1127) | must wait for focus
[task 2020-01-23T11:19:47.214Z] 11:19:47 INFO - Console message: [JavaScript Error: "[Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIControllers.removeController]" nsresult: "0x80004005 (NS_ERROR_FAILURE)" location: "JS frame :: chrome://global/content/elements/browser-custom-element.js :: destroy :: line 1352" data: no]"]
[task 2020-01-23T11:19:47.214Z] 11:19:47 INFO - destroy@chrome://global/content/elements/browser-custom-element.js:1352:28
[task 2020-01-23T11:19:47.215Z] 11:19:47 INFO - disconnectedCallback@chrome://global/content/elements/browser-custom-element.js:422:12
[task 2020-01-23T11:19:47.216Z] 11:19:47 INFO - removePreloadedBrowser@resource:///modules/NewTabPagePreloading.jsm:200:41
[task 2020-01-23T11:19:47.216Z] 11:19:47 INFO - nextTest/<@chrome://mochikit/content/browser-test.js:852:34
[task 2020-01-23T11:19:47.217Z] 11:19:47 INFO - SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:808:67
[task 2020-01-23T11:19:47.217Z] 11:19:47 INFO -
[task 2020-01-23T11:19:48.974Z] 11:19:48 INFO - GECKO(1127) | Completed ShutdownLeaks collections in process 1257
[task 2020-01-23T11:19:49.014Z] 11:19:49 INFO - GECKO(1127) | Completed ShutdownLeaks collections in process 1311
[task 2020-01-23T11:19:49.058Z] 11:19:49 INFO - GECKO(1127) | Completed ShutdownLeaks collections in process 1286
[task 2020-01-23T11:19:49.078Z] 11:19:49 INFO - GECKO(1127) | Completed ShutdownLeaks collections in process 1195
[task 2020-01-23T11:19:49.119Z] 11:19:49 INFO - GECKO(1127) | Completed ShutdownLeaks collections in process 1182
[task 2020-01-23T11:19:49.939Z] 11:19:49 INFO - GECKO(1127) | Completed ShutdownLeaks collections in process 1127
[task 2020-01-23T11:19:49.939Z] 11:19:49 INFO - TEST-START | Shutdown

Drew,
Could this be caused by the changes in Bug 1610681?

Flags: needinfo?(adw)

At first glance it seems possible, I'll take a look.

Assignee: nobody → adw
Status: NEW → ASSIGNED
Iteration: --- → 74.2 - Jan 20 - Feb 09
Points: --- → 3
Flags: needinfo?(adw)

Retriggers show this is perma-failing https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&revision=49939065bcfc315ff090a2cb773ac805904ddbb2&searchStr=windows%2C10%2Cx64%2Cshippable%2Copt%2Cmochitests%2Ctest-windows10-64-shippable%2Fopt-mochitest-browser-chrome-e10s-2%2Cm%28bc2%29&selectedJob=286848110

Summary: High frequency TEST-UNEXPECTED-FAIL | accessible/tests/browser/events/browser_test_focus_urlbar.js | Test timed out - when Gecko 74 merges to Beta on 2020-02-10 → Perma TEST-UNEXPECTED-FAIL | accessible/tests/browser/events/browser_test_focus_urlbar.js | Test timed out - when Gecko 74 merges to Beta on 2020-02-10

The test presses the down arrow key to open the view and start a search, waits for the focus event, presses the up arrow key to select the one-off search settings button, and waits for the focus event. It hangs waiting for that second event.

I think what's happening is that the search sometimes doesn't finish by the time the test presses the up arrow key to select the settings button. So it presses the up arrow key, but then UrlbarView.onQueryResults is called with results from the search. The patch in bug 1610681 added this block to onQueryResults:

if (firstResult.heuristic) {
  // Select the heuristic result.  The heuristic may not be the first result
  // added, which is why we do this check here when each result is added and
  // not above.
  ...
}

So we reach that block which then selects the first result, removing the selection from the settings button, which the test expects to be selected.

I could modify the test to wait for the search to finish, but it actually points out a problem with the patch. We should only select the first result if there's not already a selection -- I think.

And the screenshot from one of the failures seems to support that, since the first result is selected: https://firefoxci.taskcluster-artifacts.net/fNmrc-x7RfiPet9Z6mFVOQ/0/public/test_info/mozilla-test-fail-screenshot_yiw_pc.png

Blocks: 1610681

The fix to bug 1610681 needed to make sure that there's no current selection before selecting the heuristic result.

Another try run, this time with all tests, not only the failing one, and also without the 74-as-beta simulation: https://treeherder.mozilla.org/#/jobs?repo=try&revision=fb9bc560f01dab4b4edea4afe2d4767f494cd86a

Pushed by dwillcoxon@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7557c5113ce3
Don't select the heuristic result if there's already a selection. r=harry

https://hg.mozilla.org/mozilla-central/rev/7557c5113ce3

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox74: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: