1611168 - Some sync pings being rejected due to null devices.version

Status: RESOLVED FIXED

(Data Platform and Tools :: General, defect, P1)

Description

[Jeff Klukas [:klukas] (UTC-4)]

While investigating https://bugzilla.mozilla.org/show_bug.cgi?id=1610907 I found that we get about 10k sync pings per day that go to errors due to the following:

org.everit.json.schema.ValidationException: #/payload/syncs/0/devices/0/version: expected type: String, found: Null

It looks like generally, when we have null for version we also have null for os.

Comment 1

[Jeff Klukas [:klukas] (UTC-4)]

:loines - Do you know who can give input about the impact of these rejected pings and whether we should update the schema to allow null values?

Comment 2

[Leif Oines [:loines]]

I think we can probably make version and os nullable but confirming with mark - would we expect the client to not set these values in some circumstances?

Comment 3

[Mark Hammond [:markh] [:mhammond]]

Yes, version and os will be null if the device doesn't sync (ie, is "just" an fxa device) - it's even possible, but less likely, they will be null if they do sync.

Comment 4

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla-services/mozilla-pipeline-schemas/pull/490

Comment 5

[Jeff Klukas [:klukas] (UTC-4)]

The next schema deploy should pick up this change and we should start seeing records flow through to sync_v4 containing null device version.