1611174 - Clear roots related to weak references earlier in shutdown

Status: RESOLVED FIXED

(Core :: JavaScript: GC, defect, P3)

Description

[Jon Coppeard (:jonco)]

There are two kinds of engine roots that are related to weak references: kept objects and finalization group records. Both of these can entrain data that is external to the engine (unlike e.g. the atoms table which cannot).

These roots are currently cleared by GCRuntime::finishRoots which is called just before the final shutdown GC when the runtime is being destroyed. This means that any external data kept alive by them will be reported as leaked by the browser.

Instead, we should clear these as soon as we do the first shutdown GC. No JS runs after this point so this will not be observable.

Comment 1

[Jon Coppeard (:jonco)]

Attachment: Bug 1611174 - Clear roots related to weak references earlier in shutdown to prevent browser leaks r?sfink

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ff917001373e
Clear roots related to weak references earlier in shutdown to prevent browser leaks r=sfink

Comment 3

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/ff917001373e