1611193 - Limit Nvidia WebRender laptop on beta to latest windows and latest nvidia drivers

Status: VERIFIED FIXED

(Core :: Graphics: WebRender, enhancement, P1)

Description

[Jeff Muizelaar [:jrmuizel]]

This will minimize our risks here

Comment 1

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1611193 - Allow WebRender on late beta/release for recent Windows 10 builds and NVIDIA drivers.

Comment 2

[Andrew Osmond [:aosmond] (he/him)]

try on central: https://treeherder.mozilla.org/#/jobs?repo=try&revision=1ed80ec483fa0a2d01e030e3fbde67940da1b102

I manually verified this on our reference machine, forcing it to believe it has a battery to ensure we got WR.

try on beta: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ee7385bf3c97b9a1b883e1e1a59d4b6f3448d24f

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0fc48050e27a
Allow WebRender on late beta/release for recent Windows 10 builds and NVIDIA drivers. r=jrmuizel

Comment 4

[Andrew Osmond [:aosmond] (he/him)]

Comment on attachment 9123832 [details]
Bug 1611193 - Allow WebRender on late beta/release for recent Windows 10 builds and NVIDIA drivers.

Beta/Release Uplift Approval Request

• User impact if declined: WebRender will not be enabled by default for users with a battery, on the latest Windows 10 build, with the latest NVIDIA drivers.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): I verified the patch on top of mozilla/central with a local build; it hasn't been verified in nightly because it hasn't made it into central yet. If the windows/driver version is too old, then it leaves WebRender disabled.

It is not risky because it is a tweak to our WebRender decision criteria. We already ran earlier in beta with the same users and now we are selecting for a smaller subset. We are already shipping WebRender to make NVIDIA users with success.

• String changes made/needed: N/A

Comment 5

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/0fc48050e27a

Comment 6

[Ryan VanderMeulen [:RyanVM]]

I think QA should try to verify this fix if they have the right hardware and software combo to do so.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9123832 [details]
Bug 1611193 - Allow WebRender on late beta/release for recent Windows 10 builds and NVIDIA drivers.

Limits the WebRender rollout to systems with newer Windows versions and nVidia drivers. Approved for 73.0RC1.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/b99e2bc3939d

Comment 9

[Daniel Cicas [:dcicas], Release QA]

Hello,

I can confirm that webrender is turned off by default for laptops with old nvidia drivers ( August 20, 2019 in this case) on 73.0RC1.

Should this bug be verified on 74 Nightly also?

Comment 10

[Andrew Osmond [:aosmond] (he/him)]

Please do, thanks.

Comment 11

[Jeff Muizelaar [:jrmuizel]]

Daniel, can you also confirm that it's enabled with new Nvidia drivers on 73.0RC1?

Comment 12

[Daniel Cicas [:dcicas], Release QA]

Hello,

So I can confirm that with a new driver Webrender is enabled by default on 73.0RC1.

But on Fx 74.0a1 (BuildID: 20200205055433) with an old driver, Webrender is still enabled by default at start-up.

Comment 13

[Andrew Osmond [:aosmond] (he/him)]

I had to look at the patch again to see what we agreed :). We still allow old drivers on nightly, as this isn't a driver bug concern, so much as a slow roll out / minimize risk concern. So as expected, thanks!

Comment 14

[Daniel Cicas [:dcicas], Release QA]

Thank you for looking in to it, marking the bug accordingly.

Comment 15

[Asif Youssuff]

Not sure if this is the right place to call this out, but the Firefox 73 release notes doesn't specify that this is Windows only - a user noticed that discrepancy here: https://www.reddit.com/r/firefox/comments/f28sec/firefox_730_see_all_new_features_updates_and_fixes/fhc77l6/

Comment 16

[Jessie [:jbonisteel] pls NI]

Ah good catch, I will see if we can edit that.