1611197 - Remove dead code from XPCInlines.h

Status: RESOLVED FIXED

(Core :: XPConnect, task, P3)

Description

[Andrew McCreight (out of office until 8/21) [:mccr8]]

While I was poking around at some XPCOM info code in XPConnect, I noticed that there are some ancestor-related methods that aren't called. That inspired me to look at the code coverage report for XPCInlines.h, which found a few more methods that are never called, mostly on XPCCallContext.

Comment 1

[Andrew McCreight (out of office until 8/21) [:mccr8]]

Attachment: Bug 1611197, part 1 - Get rid of some unused XPCOM interface ancestor methods.

Comment 2

[Andrew McCreight (out of office until 8/21) [:mccr8]]

Attachment: Bug 1611197, part 2 - Remove some dead XPCCallContext methods.

The fields these methods deal with are not dead: they are just
interacted with via other means.

I found these via the code coverage report for XPCInlines.h.

Comment 3

[Andrew McCreight (out of office until 8/21) [:mccr8]]

Attachment: Bug 1611197, part 3 - Remove some unused hasinterface methods.

I found these via the code coverage report for XPCInlines.h.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fb11cc30f8c5
part 1 - Get rid of some unused XPCOM interface ancestor methods. r=nika
https://hg.mozilla.org/integration/autoland/rev/29d778101fae
part 2 - Remove some dead XPCCallContext methods. r=nika
https://hg.mozilla.org/integration/autoland/rev/ab2fc1f29e2c
part 3 - Remove some unused hasinterface methods. r=nika

Comment 5

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/fb11cc30f8c5
https://hg.mozilla.org/mozilla-central/rev/29d778101fae
https://hg.mozilla.org/mozilla-central/rev/ab2fc1f29e2c