1611213 - mach artifact toolchain fails during mozboot bootstrap with python 3.8

Status: RESOLVED DUPLICATE of bug 1611352

(Firefox Build System :: General, defect)

Description

[Jan Sonntag]

While trying to bootstrap with python 3.8, the following error occurs. This is because python/mozbuild/mozbuild/artifact.py tries to import urlparse which has been moved to urllib.parse in Python 3.

Error running mach:

    ['artifact', 'toolchain', '--from-build', 'linux64-node']

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.
You can invoke |./mach busted| to check if this issue is already on file. If it
isn't, please use |./mach busted file| to report it. If |./mach busted| is
misbehaving, you can also inspect the dependencies of bug 1543241.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

ModuleNotFoundError: No module named 'urlparse'

  File "/home/jansonntag/Dokumente/firefox-dev/mozilla-unified/python/mozbuild/mozbuild/artifact_commands.py", line 185, in artifact_toolchain
    from mozbuild.artifacts import ArtifactCache
  File "/home/jansonntag/Dokumente/firefox-dev/mozilla-unified/build/mach_bootstrap.py", line 431, in __call__
    module = self._original_import(name, globals, locals, fromlist, level)
  File "/home/jansonntag/Dokumente/firefox-dev/mozilla-unified/python/mozbuild/mozbuild/artifacts.py", line 51, in <module>
    import urlparse
  File "/home/jansonntag/Dokumente/firefox-dev/mozilla-unified/build/mach_bootstrap.py", line 431, in __call__
    module = self._original_import(name, globals, locals, fromlist, level)
Traceback (most recent call last):
  File "bootstrap.py", line 202, in <module>
    sys.exit(main(sys.argv))
  File "bootstrap.py", line 193, in main
    dasboot.bootstrap()
  File "../mozboot/bootstrap.py", line 519, in bootstrap
    self.maybe_install_private_packages_or_exit(state_dir,
  File "../mozboot/bootstrap.py", line 380, in maybe_install_private_packages_or_exit
    self.instance.ensure_node_packages(state_dir, checkout_root)
  File "../mozboot/linux_common.py", line 91, in ensure_node_packages
    self.install_toolchain_artifact(state_dir, checkout_root, node.LINUX)
  File "../mozboot/base.py", line 346, in install_toolchain_artifact
    subprocess.check_call(cmd, cwd=state_dir)
  File "/usr/lib/python3.8/subprocess.py", line 364, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['/usr/bin/python', '/home/jansonntag/Dokumente/firefox-dev/mozilla-unified/mach', 'artifact', 'toolchain', '--from-build', 'linux64-node']' returned non-zero exit status 1.

Comment 2

[Masatoshi Kimura [:emk]]

Please do not dupe this specific problem to a meta-bug.
Also, when will this be fixed? Now ./mach bootstrap will execute mach artifact toolchain with Python 3. (See bug 1615823)

Comment 3

[Masatoshi Kimura [:emk]]

Hm, bug 1611352 should have fixed this. Apparently bug 1615823 is a different issue.